incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anton Pevtsov" <Ant...@moscow.vdiweb.com>
Subject RE: test for lib.string.substr
Date Fri, 05 May 2006 15:40:52 GMT
I committed the test.

Martin Sebor wrote:
> PS One question: why is the "last" string always the last test case in
the array?

It is just a marker of the end of the test cases array. There is no
special need in it, I use it during the test implementation for
debugging purposes. 
Is it necessary to remove this test case?


Thanks,
Anton Pevtsov


-----Original Message-----
From: Martin Sebor [mailto:sebor@roguewave.com] 
Sent: Friday, May 05, 2006 01:37
To: stdcxx-dev@incubator.apache.org
Subject: Re: test for lib.string.substr


Anton Pevtsov wrote:
> The test for lib.string.substr is here: 
> http://people.apache.org/~antonp/stdcxx05032006/
> 
> Also there are required difference for 21.strings.cpp and 21.strings.h

> files.

Looks good! Please make the formatting changes we discussed before
committing, i.e., change

     static const TestCase void_test_cases [] = {
         ...
     };

to

     static const TestCase
     void_test_cases [] = {
         ...
     };

Thanks!
Martin

PS One question: why is the "last" string always the last test case in
the array?

Mime
View raw message