Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 54873 invoked from network); 7 Feb 2006 03:03:00 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Feb 2006 03:03:00 -0000 Received: (qmail 94741 invoked by uid 500); 7 Feb 2006 03:03:00 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 94728 invoked by uid 500); 7 Feb 2006 03:03:00 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 94717 invoked by uid 99); 7 Feb 2006 03:03:00 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2006 19:03:00 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [12.17.213.84] (HELO bco-exchange.bco.roguewave.com) (12.17.213.84) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 06 Feb 2006 19:02:59 -0800 Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id ZGW28RGY; Mon, 6 Feb 2006 19:55:02 -0700 Message-ID: <43E80EC6.5070700@roguewave.com> Date: Mon, 06 Feb 2006 20:06:46 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: test for lib.alg.partitions References: <43E77C2F.5080409@moscow.vdiweb.com> In-Reply-To: <43E77C2F.5080409@moscow.vdiweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Anton Pevtsov wrote: > Martin, here is the updated test version - I added checks for X objects > leaks (or unexpected dtor calls). Great! I updated the test with this change: http://svn.apache.org/viewcvs.cgi?rev=375448&view=rev The test still aborts due to the bug you mentioned but passes with your suggested patch so it looks like we have a solution. Unless you can think of any reason why we shouldn't apply it I'll go ahead and commit it tomorrow. > I plan to implement the exception-safity test for this algorithm Okay. > (and I > think we need to implement such tests for each algorithm, don't we?). Yes, eventually we should. Please open an enhancement in Jira so we don't forget. For now, let's just enhance the tests that are the most likely to have problems. I.e., any tests that allocate any temporary storage (other than on the stack). Thanks Martin