incubator-stdcxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Liviu Nicoara <nico...@roguewave.com>
Subject Re: 23.containers.deque.modifiers.cpp
Date Mon, 23 Jan 2006 23:14:26 GMT
Take two with corrections to add z modifier to size_t arguments.

Liviu Nicoara wrote:
> I have attached a second version of the test. Please let me know if this
> addresses the points you raised.
> 
> Thanks,
> Liviu
> 
> Liviu Nicoara wrote:
> 
>>Martin Sebor wrote:
>>
>>
>>>Liviu Nicoara wrote:
>>>
>>>
>>>
>>>>I have attached my tentative porting of lib.deque.modifiers test to the
>>>>new driver. Martin, I would appreciate suggestions for improving the
>>>>sections which use ToString class (one of those uses split formatting).
>>>
>>>
>>>I don't see the class defined in the test. Did you by any chance
>>>move/copy it into your version alg_test.h?
>>
>>
>>Yes, I did. My bad, I just wanted to get your feed-back on the
>>formatting bits and I didn't think that was important. I will stick a
>>ToString in each of the tests using it.
>>
>>
>>
>>>I think the bits that use the ToString class are fine. As soon as
>>>I'm done with the extension to rw_asnprintf() to format arrays of
>>>class X (we need to rename it!) it should be straightforward to
>>>simply remove the class and pass the arrays directly to rw_assert().
>>
>>
>>Super.
>>
>>
>>
>>>Btw., the old tests were designed to avoid invoking the RW_ASSERT
>>>macro except on failure (i.e., there's usually an if (failed) { }
>>>block around it). 
>>
>>
>>I got that. I will eliminate the conditionals from now on.
>>
>>Thanks,
>>Liviu
>>
> 
> 
> 


Mime
View raw message