Return-Path: Delivered-To: apmail-incubator-stdcxx-dev-archive@www.apache.org Received: (qmail 36191 invoked from network); 23 Dec 2005 23:45:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 23 Dec 2005 23:45:41 -0000 Received: (qmail 20959 invoked by uid 500); 23 Dec 2005 23:45:41 -0000 Delivered-To: apmail-incubator-stdcxx-dev-archive@incubator.apache.org Received: (qmail 20937 invoked by uid 500); 23 Dec 2005 23:45:40 -0000 Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: stdcxx-dev@incubator.apache.org Delivered-To: mailing list stdcxx-dev@incubator.apache.org Received: (qmail 20925 invoked by uid 99); 23 Dec 2005 23:45:40 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2005 15:45:40 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [12.17.213.84] (HELO bco-exchange.bco.roguewave.com) (12.17.213.84) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Dec 2005 15:45:38 -0800 Received: from [10.70.3.113] (10.70.3.113 [10.70.3.113]) by bco-exchange.bco.roguewave.com with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2657.72) id ZGW27ZAG; Fri, 23 Dec 2005 16:39:33 -0700 Message-ID: <43AC8CDD.60908@roguewave.com> Date: Fri, 23 Dec 2005 16:48:45 -0700 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20050920 X-Accept-Language: en-us, en MIME-Version: 1.0 To: stdcxx-dev@incubator.apache.org Subject: Re: [Re: [Fwd: Solution generartion script for Intel 9.0 compiler]] References: <43AAC71A.7060604@moscow.vdiweb.com> In-Reply-To: <43AAC71A.7060604@moscow.vdiweb.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Anton Pevtsov wrote: > Martin Sebor wrote: > >>> Now that we have this resolved we can commit the changes. >>> Anton, could you please send a ChangeLog entry describing all the >>> changes you made? >> >> >> > > Yes, see the description below, please. Thanks! I've applied your patch and committed it with this change: http://svn.apache.org/viewcvs.cgi?rev=358881&view=rev Just a comment on the ChangeLog entries. The expected format is as follows: * (symbol): Description of changes. (symbol): Description of changes. ... * (symbol): Description of changes. ... Here's a pretty good convention to follow: http://www.gnu.org/prep/standards/standards.html#Change-Logs > [...] > > * config.js: > Added library directories collection into the Linker "class" So this should be * config.js (Linker): Added library directories collection. and similarly for all other changes. In big patches like this one it's important to list each changed function (or symbol) separately, especially when there is more than one change in the same file. Martin