Mailing-List: contact stdcxx-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: stdcxx-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: local policy)
Message-ID: <42F2C101.5090704@roguewave.com>
Date: Thu, 04 Aug 2005 19:29:37 -0600
From: Martin Sebor <sebor@roguewave.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050716
MIME-Version: 1.0
To: Nicole Willson <willson@roguewave.com>
CC: stdcxx-dev@incubator.apache.org
Subject: Re: [PATCH] STDCXX-11: IA64 32-bit atomic operations broken
References: 
 <4FA4B7B3231C5D459E7BAD020213A94202948E29@bco-exchange.bco.roguewave.com>
In-Reply-To: 
 <4FA4B7B3231C5D459E7BAD020213A94202948E29@bco-exchange.bco.roguewave.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Nicole Willson wrote:
> Ok, apparently attachments are not allowed on this list.  So, here it
> is:

Thanks!

I assume atomic.s also needs to be changed to conditionally #include
this file. With that the core dump in STDCXX-11 indeed goes away. Cool!

Comparing the two atomic-ia64 files, I see that this one is missing the
__rw_atomic_xxx64() functions. They are needed to atomically manipulate
long longs. I added them to your patch. To enable them I also changed
include/rw/_mutex.h and added the corresponding overloads of the
__rw_atomic_pre{inc,dec}rement() and __rw_atomic_exchange() for long
long. You might want to do the same on your branch.

Here's the svn commit:
http://svn.apache.org/viewcvs.cgi?rev=230382&view=rev

Martin