incubator-sling-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bdelacre...@apache.org
Subject svn commit: r1565699 - /sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java
Date Fri, 07 Feb 2014 16:01:35 GMT
Author: bdelacretaz
Date: Fri Feb  7 16:01:35 2014
New Revision: 1565699

URL: http://svn.apache.org/r1565699
Log:
SLING-3320 - comment on possible inconsistency

Modified:
    sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java

Modified: sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java?rev=1565699&r1=1565698&r2=1565699&view=diff
==============================================================================
--- sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java
(original)
+++ sling/trunk/bundles/scripting/core/src/main/java/org/apache/sling/scripting/core/impl/ContextBvpCollector.java
Fri Feb  7 16:01:35 2014
@@ -85,6 +85,12 @@ class ContextBvpCollector {
 
     public void modifiedService(final ServiceReference ref) {
         removedService(ref);
+        // Note that any calls to our get* methods at this
+        // point won't see the service. We could synchronize
+        // to make sure this methods acts atomically, but it
+        // doesn't seem worth it, as we don't expect BVPs to 
+        // be modified often. Living with that small inconsistency
+        // is probably worth it for the sake of simpler code.
         addingService(ref);
     }
 



Mime
View raw message