Return-Path: Delivered-To: apmail-sling-commits-archive@www.apache.org Received: (qmail 86424 invoked from network); 18 Jan 2010 21:14:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 18 Jan 2010 21:14:09 -0000 Received: (qmail 38060 invoked by uid 500); 18 Jan 2010 21:14:09 -0000 Delivered-To: apmail-sling-commits-archive@sling.apache.org Received: (qmail 38010 invoked by uid 500); 18 Jan 2010 21:14:09 -0000 Mailing-List: contact commits-help@sling.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@sling.apache.org Delivered-To: mailing list commits@sling.apache.org Received: (qmail 38001 invoked by uid 99); 18 Jan 2010 21:14:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2010 21:14:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2010 21:14:08 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 4C6F0238897D; Mon, 18 Jan 2010 21:13:48 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r900561 - /sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java Date: Mon, 18 Jan 2010 21:13:48 -0000 To: commits@sling.apache.org From: cziegeler@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100118211348.4C6F0238897D@eris.apache.org> Author: cziegeler Date: Mon Jan 18 21:13:47 2010 New Revision: 900561 URL: http://svn.apache.org/viewvc?rev=900561&view=rev Log: Code cleanup Modified: sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java Modified: sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java URL: http://svn.apache.org/viewvc/sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java?rev=900561&r1=900560&r2=900561&view=diff ============================================================================== --- sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java (original) +++ sling/trunk/contrib/scripting/java/src/main/java/org/apache/sling/scripting/java/jdt/CompilationUnit.java Mon Jan 18 21:13:47 2010 @@ -213,22 +213,25 @@ * @see org.eclipse.jdt.internal.compiler.env.INameEnvironment#isPackage(char[][], char[]) */ public boolean isPackage(char[][] parentPackageName, char[] packageName) { - StringBuilder result = new StringBuilder(); + if (Character.isUpperCase(packageName[0])) { + return false; + } + final StringBuilder builder = new StringBuilder(); if (parentPackageName != null) { for (int i = 0; i < parentPackageName.length; i++) { if (i > 0) { - result.append("."); + builder.append("."); } - result.append(parentPackageName[i]); + builder.append(parentPackageName[i]); } } - String str = new String(packageName); - if (Character.isUpperCase(str.charAt(0)) && !isPackage(result.toString())) { - return false; + if (!isPackage(builder.toString())) { + return false; } - result.append("."); - result.append(str); - return isPackage(result.toString()); + builder.append("."); + builder.append(packageName); + + return isPackage(builder.toString()); } /**