Return-Path: Delivered-To: apmail-incubator-sling-commits-archive@locus.apache.org Received: (qmail 28544 invoked from network); 3 Jun 2008 11:36:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jun 2008 11:36:53 -0000 Received: (qmail 87048 invoked by uid 500); 3 Jun 2008 11:36:56 -0000 Delivered-To: apmail-incubator-sling-commits-archive@incubator.apache.org Received: (qmail 87017 invoked by uid 500); 3 Jun 2008 11:36:56 -0000 Mailing-List: contact sling-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: sling-dev@incubator.apache.org Delivered-To: mailing list sling-commits@incubator.apache.org Received: (qmail 87007 invoked by uid 99); 3 Jun 2008 11:36:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 04:36:56 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 11:36:06 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 6F7B42388A16; Tue, 3 Jun 2008 04:36:23 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r662747 - in /incubator/sling/trunk: engine/ engine/src/main/java/org/apache/sling/engine/impl/log/ engine/src/main/resources/OSGI-INF/ engine/src/main/resources/OSGI-INF/metatype/ engine/src/main/resources/OSGI-INF/scr-plugin/ jcr/jackrabb... Date: Tue, 03 Jun 2008 11:36:22 -0000 To: sling-commits@incubator.apache.org From: fmeschbe@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080603113623.6F7B42388A16@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: fmeschbe Date: Tue Jun 3 04:36:22 2008 New Revision: 662747 URL: http://svn.apache.org/viewvc?rev=662747&view=rev Log: SLING-502 Create manual Declarative Service descriptors for component factories to make them usable both in Felix SCR 1.0.0 and and later implementations as well as in Equinox DS. See issue for details. Added: incubator/sling/trunk/engine/src/main/resources/OSGI-INF/manual_serviceComponents.xml incubator/sling/trunk/engine/src/main/resources/OSGI-INF/metatype/metatype.xml incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/ incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/scrinfo.xml incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/manual_serviceComponents.xml incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/metatype/metatype.xml incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/manual_serviceComponents.xml incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/metatype/metatype.xml Modified: incubator/sling/trunk/engine/pom.xml incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java incubator/sling/trunk/jcr/jackrabbit-client/pom.xml incubator/sling/trunk/jcr/jackrabbit-server/pom.xml Modified: incubator/sling/trunk/engine/pom.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/engine/pom.xml?rev=662747&r1=662746&r2=662747&view=diff ============================================================================== --- incubator/sling/trunk/engine/pom.xml (original) +++ incubator/sling/trunk/engine/pom.xml Tue Jun 3 04:36:22 2008 @@ -79,6 +79,11 @@ commons-fileupload + + + OSGI-INF/manual_serviceComponents.xml, + OSGI-INF/serviceComponents.xml + Modified: incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java URL: http://svn.apache.org/viewvc/incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java?rev=662747&r1=662746&r2=662747&view=diff ============================================================================== --- incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java (original) +++ incubator/sling/trunk/engine/src/main/java/org/apache/sling/engine/impl/log/RequestLoggerService.java Tue Jun 3 04:36:22 2008 @@ -25,13 +25,14 @@ import org.apache.sling.engine.RequestLog; import org.apache.sling.engine.impl.SlingHttpServletResponseImpl; import org.osgi.framework.BundleContext; +import org.osgi.framework.ServiceRegistration; import org.osgi.service.component.ComponentContext; /** * The RequestLoggerService is a factory component which gets * configuration to register loggers for the {@link RequestLogger}. * - * @scr.component label="%request.log.service.name" + * @ scr.component label="%request.log.service.name" * description="%request.log.service.description" * factory="org.apache.sling.engine.impl.log.RequestLoggerService" * @scr.property name="service.vendor" value="The Apache Software Foundation" @@ -123,12 +124,26 @@ // ---------- SCR integration ---------------------------------------------- + // manual service registration due to component factory bug in Felix SCR 1.0.0 + private ServiceRegistration serviceRegistration; + @SuppressWarnings("unchecked") protected void activate(ComponentContext context) { this.setup(context.getBundleContext(), context.getProperties()); + + // SLING-502: do manually due to component factory bug in Felix SCR 1.0.0 + serviceRegistration = context.getBundleContext().registerService( + "org.apache.sling.engine.impl.log.RequestLoggerService", this, + context.getProperties()); } protected void deactivate(ComponentContext context) { + // SLING-502: do manually due to component factory bug in Felix SCR 1.0.0 + if (serviceRegistration != null) { + serviceRegistration.unregister(); + serviceRegistration = null; + } + this.shutdown(); } Added: incubator/sling/trunk/engine/src/main/resources/OSGI-INF/manual_serviceComponents.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/engine/src/main/resources/OSGI-INF/manual_serviceComponents.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/engine/src/main/resources/OSGI-INF/manual_serviceComponents.xml (added) +++ incubator/sling/trunk/engine/src/main/resources/OSGI-INF/manual_serviceComponents.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,22 @@ + + + + + + + + + + + + + Added: incubator/sling/trunk/engine/src/main/resources/OSGI-INF/metatype/metatype.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/engine/src/main/resources/OSGI-INF/metatype/metatype.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/engine/src/main/resources/OSGI-INF/metatype/metatype.xml (added) +++ incubator/sling/trunk/engine/src/main/resources/OSGI-INF/metatype/metatype.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,85 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Added: incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/scrinfo.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/scrinfo.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/scrinfo.xml (added) +++ incubator/sling/trunk/engine/src/main/resources/OSGI-INF/scr-plugin/scrinfo.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,27 @@ + + + + + + + + + + + + + + + + Modified: incubator/sling/trunk/jcr/jackrabbit-client/pom.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-client/pom.xml?rev=662747&r1=662746&r2=662747&view=diff ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-client/pom.xml (original) +++ incubator/sling/trunk/jcr/jackrabbit-client/pom.xml Tue Jun 3 04:36:22 2008 @@ -51,10 +51,12 @@ + org.apache.felix maven-bundle-plugin @@ -75,6 +77,10 @@ org.osgi.service.log, * + + + OSGI-INF/manual_serviceComponents.xml + Added: incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/manual_serviceComponents.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/manual_serviceComponents.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/manual_serviceComponents.xml (added) +++ incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/manual_serviceComponents.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,37 @@ + + + + + + + + + + + + + + + + + + + + + + + Added: incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/metatype/metatype.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/metatype/metatype.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/metatype/metatype.xml (added) +++ incubator/sling/trunk/jcr/jackrabbit-client/src/main/resources/OSGI-INF/metatype/metatype.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,54 @@ + + + + + + + + + + + + + + + + + + + + + Modified: incubator/sling/trunk/jcr/jackrabbit-server/pom.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-server/pom.xml?rev=662747&r1=662746&r2=662747&view=diff ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-server/pom.xml (original) +++ incubator/sling/trunk/jcr/jackrabbit-server/pom.xml Tue Jun 3 04:36:22 2008 @@ -50,10 +50,12 @@ + org.apache.felix maven-bundle-plugin @@ -98,6 +100,10 @@ nekohtml, xercesImpl + + + OSGI-INF/manual_serviceComponents.xml + Added: incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/manual_serviceComponents.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/manual_serviceComponents.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/manual_serviceComponents.xml (added) +++ incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/manual_serviceComponents.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,78 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Added: incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/metatype/metatype.xml URL: http://svn.apache.org/viewvc/incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/metatype/metatype.xml?rev=662747&view=auto ============================================================================== --- incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/metatype/metatype.xml (added) +++ incubator/sling/trunk/jcr/jackrabbit-server/src/main/resources/OSGI-INF/metatype/metatype.xml Tue Jun 3 04:36:22 2008 @@ -0,0 +1,78 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + +