incubator-sling-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fmesc...@apache.org
Subject svn commit: r619367 - in /incubator/sling/trunk/scripting/resolver/src: main/java/org/apache/sling/scripting/resolver/ test/java/org/apache/sling/scripting/resolver/
Date Thu, 07 Feb 2008 11:34:05 GMT
Author: fmeschbe
Date: Thu Feb  7 03:33:59 2008
New Revision: 619367

URL: http://svn.apache.org/viewvc?rev=619367&view=rev
Log:
SLING-234 RequestDispatcherOptions parsing has been moved to a
constructor. So we drop the parser and unit test here

Removed:
    incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/RequestDispatcherOptionsParser.java
    incubator/sling/trunk/scripting/resolver/src/test/java/org/apache/sling/scripting/resolver/RequestDispatcherOptionsParserTest.java
Modified:
    incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/ScriptHelper.java

Modified: incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/ScriptHelper.java
URL: http://svn.apache.org/viewvc/incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/ScriptHelper.java?rev=619367&r1=619366&r2=619367&view=diff
==============================================================================
--- incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/ScriptHelper.java
(original)
+++ incubator/sling/trunk/scripting/resolver/src/main/java/org/apache/sling/scripting/resolver/ScriptHelper.java
Thu Feb  7 03:33:59 2008
@@ -32,8 +32,6 @@
 import org.apache.sling.api.scripting.SlingScriptHelper;
 import org.apache.sling.scripting.resolver.impl.helper.OnDemandReaderRequest;
 import org.apache.sling.scripting.resolver.impl.helper.OnDemandWriterResponse;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * Simple script helper providing access to the (wrapped) response, the
@@ -49,8 +47,6 @@
 
     private final SlingHttpServletResponse response;
 
-    private final Logger log = LoggerFactory.getLogger(ScriptHelper.class);
-
     public ScriptHelper(SlingScript script, SlingHttpServletRequest request,
             SlingHttpServletResponse response) {
         this.script = script;
@@ -82,10 +78,7 @@
 
     /** Include the output of another request, using specified options */
     public void include(String path, String options) {
-        final RequestDispatcherOptionsParser parser = new RequestDispatcherOptionsParser();
-        final RequestDispatcherOptions opt = parser.parse(options);
-
-        include(path, opt);
+        include(path, new RequestDispatcherOptions(options));
     }
 
     /** Include the output of another request, using specified options */



Mime
View raw message