From sanselan-dev-return-160-apmail-incubator-sanselan-dev-archive=incubator.apache.org@incubator.apache.org Wed Apr 23 09:02:10 2008 Return-Path: Delivered-To: apmail-incubator-sanselan-dev-archive@locus.apache.org Received: (qmail 87366 invoked from network); 23 Apr 2008 09:02:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Apr 2008 09:02:10 -0000 Received: (qmail 50837 invoked by uid 500); 23 Apr 2008 09:02:12 -0000 Delivered-To: apmail-incubator-sanselan-dev-archive@incubator.apache.org Received: (qmail 50813 invoked by uid 500); 23 Apr 2008 09:02:11 -0000 Mailing-List: contact sanselan-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: sanselan-dev@incubator.apache.org Delivered-To: mailing list sanselan-dev@incubator.apache.org Received: (qmail 50802 invoked by uid 99); 23 Apr 2008 09:02:11 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Apr 2008 02:02:11 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of charlesmchen@gmail.com designates 64.233.182.190 as permitted sender) Received: from [64.233.182.190] (HELO nf-out-0910.google.com) (64.233.182.190) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 Apr 2008 09:01:27 +0000 Received: by nf-out-0910.google.com with SMTP id k4so1302411nfd.40 for ; Wed, 23 Apr 2008 02:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=KDe2eqaoF3lX7F7CpCrgOfy85yu5jtURBRyBPodhMgc=; b=mYAzwijUGXecQNW5d5HaeuOEKPmpQbxT4GLWzkvzCHMbQU/zGFOpbOxmpbwXxwHLVfyT6h2ZoS/SEm7JXFiBSOnubor1Yc4dmQdjI6VMLAuVfK8lAZ9pL9Qr4KfIPwv2pC8/pvSvvlXV0OIIuDdcPU9YdNa0IYf0wpavty3ATjw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=DljOgX4ja5grWXA42W2vvjzjiRuhtcfvYed+pYx9L19+mCVdF1+2LaqO2eX+SpBpEukiDxW86venVQUpLUqczdHs/5z6ksfYb1n+HJgjyIciTpDZlfV45gGxjQHvBuwdSq9ALsHuUg/9A+ZoJqOf5O7plD4pXsj4NkPzu9/Wn+g= Received: by 10.78.134.7 with SMTP id h7mr625706hud.76.1208941300101; Wed, 23 Apr 2008 02:01:40 -0700 (PDT) Received: by 10.78.106.7 with HTTP; Wed, 23 Apr 2008 02:01:40 -0700 (PDT) Message-ID: Date: Wed, 23 Apr 2008 11:01:40 +0200 From: "Charles Matthew Chen" To: "Jon Anders Amundsen" Subject: Re: Small bug in Sanselan Cc: sanselan-dev@incubator.apache.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org Hi Jon, Thanks so much for the patch. I'm aiming to do a new build soon and I'll be sure to include it. Thanks, Charles. ps. I've cc'd the sanselan-dev mailing list. On Tue, Apr 22, 2008 at 5:41 PM, Jon Anders Amundsen wrote: > Hi! > > I want to report a small bug in Sanselan in the convenience functions to > read GPS data. > > In the class org.cmc.sanselan.formats.tiff.TiffImageMetadata.GPSInfo there > are two functions called getLongitudeAsDegreesEast() and > getLatitudeAsDegreesNorth() which is affected by the bug. > These functions will return a position that may be several kilometers wrong > because of a small calculation error. These two functions assume that there > are 360 seconds in one degree, while the correct number is 3600. This is on > line number 369 and 384 (according to the file in release 0.91). > > I have attached a .diff-file that will fix the bug. > > -- > Jon Anders Amundsen > MSc Student at the Norwegian University of Science and Technology > Department of Computer and Information Science >