From sanselan-dev-return-32-apmail-incubator-sanselan-dev-archive=incubator.apache.org@incubator.apache.org Fri Oct 12 03:45:17 2007 Return-Path: Delivered-To: apmail-incubator-sanselan-dev-archive@locus.apache.org Received: (qmail 12485 invoked from network); 12 Oct 2007 03:45:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Oct 2007 03:45:17 -0000 Received: (qmail 76401 invoked by uid 500); 12 Oct 2007 03:45:05 -0000 Delivered-To: apmail-incubator-sanselan-dev-archive@incubator.apache.org Received: (qmail 76383 invoked by uid 500); 12 Oct 2007 03:45:05 -0000 Mailing-List: contact sanselan-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: sanselan-dev@incubator.apache.org Delivered-To: mailing list sanselan-dev@incubator.apache.org Received: (qmail 76374 invoked by uid 99); 12 Oct 2007 03:45:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Oct 2007 20:45:05 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of charlesmchen@gmail.com designates 64.233.182.186 as permitted sender) Received: from [64.233.182.186] (HELO nf-out-0910.google.com) (64.233.182.186) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2007 03:45:09 +0000 Received: by nf-out-0910.google.com with SMTP id k4so721390nfd for ; Thu, 11 Oct 2007 20:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=4nNcKqpShzgc/ym3ylEiuvrWYUs6CI24XXXhIffzMR4=; b=NcsG7ue8sfpy6ehyuJNdE+2h/S4hkthkt08ySFJtRSAbq2wqRxIU2axJBIPmuoQ1ltBGj27Sw7sGcSeTX1xlNmp3w8AXF/0r8EMSvNlojcoonERvvOEBRBRb4o+F/HyEANsIL5iU5vpdz8Er/bq/MSe3mLxAlNW8BS7iszBDJB0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sgC2UrTRIDWVzr/DSlw48ZWfNhz3ZYGpfAtHEGR5gf36mMOXy8yqEVASp36IJ1ZbktNzSRaGXi/UrxXCGCZiR6Kfp+YbgkhVUX+kwDo1srkJIrUUmDI1Q7dOAiRBlvRc8OTlFhTfJiIWBnjam53zveuuFpjN7S7JR7L5N1YKI00= Received: by 10.78.157.19 with SMTP id f19mr1972845hue.1192160687592; Thu, 11 Oct 2007 20:44:47 -0700 (PDT) Received: by 10.78.130.9 with HTTP; Thu, 11 Oct 2007 20:44:47 -0700 (PDT) Message-ID: Date: Thu, 11 Oct 2007 23:44:47 -0400 From: "Charles Matthew Chen" To: sanselan-dev@incubator.apache.org Subject: Re: [jira] Commented: (SANSELAN-1) Initial code drop In-Reply-To: <31953032.1191802610577.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <22535470.1191729410555.JavaMail.jira@brutus> <31953032.1191802610577.JavaMail.jira@brutus> X-Virus-Checked: Checked by ClamAV on apache.org > The structure is fine. Tests can be added to the directory structure parallel to main. Have you thought about unit testing? I have a suite of unit tests but they depend on my image library which I do not own the IP rights to. Many were given to me as part of bug reports. I'm going to start working on a new suite of unit tests. What's the policy for adding this kind of data to the repo? Is it sufficient for the image to be in the public domain, or do we need a CLA (or some such) from each image source? > What should the svn eol style be for the project? I've used LF and native for different projects, and now use LF because the Windows users I work with mostly use unix tools not Windows tools so they prefer LF. > > Formatting seems to use tabs not blanks for indenting. This is a user choice and my recommendation is for four spaces no tabs but this is just a community decision that needs to be made. > > eol style and formatting: need to discuss some more. I have no strong opinion about eols & indents. Charles.