incubator-sanselan-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Matthew Chen" <charlesmc...@gmail.com>
Subject Re: [jira] Commented: (SANSELAN-1) Initial code drop
Date Fri, 12 Oct 2007 03:44:47 GMT
> The structure is fine. Tests can be added to the directory structure parallel to main.
Have you thought about unit testing?

   I have a suite of unit tests but they depend on my image library
which I do not own the IP rights to.  Many were given to me as part of
bug reports.  I'm going to start working on a new suite of unit tests.

   What's the policy for adding this kind of data to the repo?  Is it
sufficient for the image to be in the public domain, or do we need a
CLA (or some such) from each image source?

> What should the svn eol style be for the project? I've used LF and native for different
projects, and now use LF because the Windows users I work with mostly use unix tools not Windows
tools so they prefer LF.
>
> Formatting seems to use tabs not blanks for indenting. This is a user choice and my recommendation
is for four spaces no tabs but this is just a community decision that needs to be made.
>
> eol style and formatting: need to discuss some more.

   I have no strong opinion about eols & indents.

Charles.

Mime
View raw message