incubator-sanselan-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig Russell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SANSELAN-1) Initial code drop
Date Mon, 08 Oct 2007 00:16:50 GMT

    [ https://issues.apache.org/jira/browse/SANSELAN-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533012
] 

Craig Russell commented on SANSELAN-1:
--------------------------------------

Just a few comments to get started. 

Good to have the Apache license done already.

The structure is fine. Tests can be added to the directory structure parallel to main. Have
you thought about unit testing? 

What should the svn eol style be for the project? I've used LF and native for different projects,
and now use LF because the Windows users I work with mostly use unix tools not Windows tools
so they prefer LF.

Formatting seems to use tabs not blanks for indenting. This is a user choice and my recommendation
is for four spaces no tabs but this is just a community decision that needs to be made.

So, bottom line: 
license: check.
directory structure: check.
eol style and formatting: need to discuss some more.


> Initial code drop
> -----------------
>
>                 Key: SANSELAN-1
>                 URL: https://issues.apache.org/jira/browse/SANSELAN-1
>             Project: Sanselan
>          Issue Type: New Feature
>            Reporter: Craig Russell
>            Assignee: Carsten Ziegeler
>         Attachments: patch_init.zip
>
>
> This issue is to discuss the initial code drop into the project.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message