incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthieu Morel <mmo...@apache.org>
Subject Re: Stream class sender definition
Date Thu, 14 Mar 2013 13:43:51 GMT

On Mar 14, 2013, at 12:58 , Dingyu Yang wrote:

> Hi, all,
> I see the code of Stream class:
> 
>    final private Sender sender;
>    final private ReceiverImpl receiver;
> 
> should Sender be SenderImpl ?

actually the receiver should be declared as "Receiver". This is not the case because of some
method we use in ReceiverImpl that were not pushed to the interface.

We should probably improve that but that should not affect operations, since ReceiverImpl
is really the default implementation for Receiver, and it should not be necessary to inject
some other implementation.

Thanks for pointing this out,

Regards,

Matthieu


Mime
View raw message