incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-109) TCPEmitter#send() should return false when it doesn't send a packet across
Date Mon, 21 Jan 2013 18:24:13 GMT

    [ https://issues.apache.org/jira/browse/S4-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558958#comment-13558958
] 

Karthik Kambatla commented on S4-109:
-------------------------------------

Thanks Matthieu. Returning a future makes a lot more sense, and captures best my original
intention of being able to communicate potential failures.

I got confused with the branches, was looking at the piper branch all this while. Let me take
a closer look at dev. If we have not already, we should attempt at augmenting the API to return
a Future.
                
> TCPEmitter#send() should return false when it doesn't send a packet across
> --------------------------------------------------------------------------
>
>                 Key: S4-109
>                 URL: https://issues.apache.org/jira/browse/S4-109
>             Project: Apache S4
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 0.6
>
>         Attachments: s4-109.patch
>
>
> In TCPEmitter, send() calls sendMessage() which silently discards message if it can't
connect to the Listener. Instead, it should return false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message