incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthieu Morel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-109) TCPEmitter#send() should return false when it doesn't send a packet across
Date Mon, 21 Jan 2013 14:10:23 GMT

    [ https://issues.apache.org/jira/browse/S4-109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13558783#comment-13558783
] 

Matthieu Morel commented on S4-109:
-----------------------------------

Thanks Karthik!
However, we recently merged S4-95 branch into dev so the patch proposed here would not apply.
Also, in the new implementation, the emitter first acquires a permit (so it can actually write
on the TCP channel), before the message can be sent. The actual write is an asynchronous operation.
 
In this case what would be the meaning of returning a boolean? We could return a future though,
in case the sender might want to do something about that. In particular, this information
could be useful in some implementations of sender executors.
                
> TCPEmitter#send() should return false when it doesn't send a packet across
> --------------------------------------------------------------------------
>
>                 Key: S4-109
>                 URL: https://issues.apache.org/jira/browse/S4-109
>             Project: Apache S4
>          Issue Type: Bug
>    Affects Versions: 0.5.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>             Fix For: 0.6
>
>         Attachments: s4-109.patch
>
>
> In TCPEmitter, send() calls sendMessage() which silently discards message if it can't
connect to the Listener. Instead, it should return false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message