incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Patrick Hunt <ph...@apache.org>
Subject Re: S4 first release: are we OK?
Date Sun, 29 Jul 2012 04:34:04 GMT
Some comments:

1) .zip for the artifacts is a bit unusual (not a real problem
though), why not .tar.gz?

2) signing looks good

3) why are you shipping jars in the src artifact? is this really necessary?

4) your src license includes licenses for files not actually in the
artifact. You'll need separate licenses for src and bin, where src
license includes only for those in the artifact.

5) the jars in the bin seem ok, however there are some I'm not
familiar with. Have you checked that all included jars are cat A?

junit for example is cddl which is cat b and best left out. I'd leave
out all the test specific jars.

6) the notice file for the bin is the same as the NOTICE file for the
src artifact. See the Apache license - you need to ensure that the
binary artifact includes all the notices of included binaries. In some
cases this is included in the jar file of the included binary itself,
but you need to check this.

7) I quickly ran through the checklist
http://incubator.apache.org/guides/releasemanagement.html#check-list

and everything seemed fine except for the noted items.

Patrick

On Sat, Jul 28, 2012 at 10:51 AM, Matthieu Morel <mmorel@apache.org> wrote:
> Thanks for checking Kishore!
>
>>> README. artefacts --> artifacts.
> Actually both are orthographically correct, artefact is the british version.
> I will change the text if it's deemed necessary.
>
>
>>> local maven repository should probably be local gradle cache
> Since we use the maven plugin for gradle, "gradlew install" installs
> artifacts in the local maven repository.
>
>
>>> gradlew install fails saying
>>>
>>> * What went wrong:
>>> Task 'install' not found in root project
>>> 'apache-s4-0.5.0-incubating-bin'.
>
> As Flavio commented, I'm not sure we need to provide a task to install
> artifacts locally for the binary package. S4 libraries and dependencies are
> available in the lib directory and referenced from S4 scripts.
>
> What we'll need though is to publish those artifacts to a public maven
> repository. We'll do that once the release is accepted.
>
> Thanks again,
>
> Matthieu
>
>
> On 7/28/12 7:01 PM, Flavio Junqueira wrote:
>>
>> Should "gradlew install" work for the bin package? it works for me for the
>> src package, but not for the bin package. I thought this behavior was
>> correct.
>>
>> -Flavio
>>
>> On Jul 28, 2012, at 6:56 PM, kishore g wrote:
>>
>>> README. artefacts --> artifacts.
>>> local maven repository should probably be local gradle cache
>>>
>>> gradlew install fails saying
>>>
>>> * What went wrong:
>>> Task 'install' not found in root project
>>> 'apache-s4-0.5.0-incubating-bin'.
>>>
>>> I downloaded the zip and tried it on my MAC
>>>
>>>
>>>
>>> On Fri, Jul 27, 2012 at 12:59 PM, Matthieu Morel <mmorel@apache.org>
>>> wrote:
>>>
>>>> On 7/27/12 6:15 PM, Flavio Junqueira wrote:
>>>>
>>>>> I checked that the src package compiles. I'm missing a LICENSE file
>>>>> containing the licenses of all binaries we have in lib/. Have I
>>>>> overlooked
>>>>> it?
>>>>>
>>>>
>>>> You are right, thanks for checking, and apologies for missing the most
>>>> obvious!
>>>>
>>>> I also updated the release by adding the license file, and also added
>>>> the
>>>> CDDL 1.0 license for libraries that are indirectly referenced and
>>>> included
>>>> in the binary release.
>>>>
>>>> I have pushed a new commit for these modifications, retagged, recreated
>>>> the packages and uploaded them to the same place (still release
>>>> candidate
>>>> 1, as we haven't submitted to vote yet)
>>>>
>>>> Thanks!
>>>>
>>>> Matthieu
>>>>
>>>>
>>>>
>>>>> -Flavio
>>>>>
>>>>> On Jul 26, 2012, at 5:08 PM, Matthieu Morel wrote:
>>>>>
>>>>> Hi,
>>>>>>
>>>>>>
>>>>>> I have prepared a release for S4. Version is 0.5.0-incubating. There
>>>>>> are
>>>>>> 2 packages: binary and source.
>>>>>>
>>>>>> Available here :
>>>>>> http://people.apache.org/~**mmorel/s4-0.5.0-incubating-**
>>>>>>
>>>>>> release-candidate-1/<http://people.apache.org/~mmorel/s4-0.5.0-incubating-release-candidate-1/>
>>>>>>
>>>>>> * I did a legal audit and added corresponding references to licenses
>>>>>> * checked files with RAT: only derived files, docs, and config files
>>>>>> are
>>>>>> reported, so I assume it's OK.
>>>>>> * signed and checksumed the packages (KEYS file is in
>>>>>>
>>>>>> svn.apache.org/repos/asf/**incubator/s4/dist/KEYS<http://svn.apache.org/repos/asf/incubator/s4/dist/KEYS>
>>>>>> )
>>>>>> * tested
>>>>>>
>>>>>> I now plan to send a vote request to the general incubator list,
using
>>>>>> the standard voting template.
>>>>>>
>>>>>> Since it's the first release, I was wondering whether I was missing
>>>>>> something?
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> Matthieu
>>>>>>
>>>>>
>>>>>
>>>>
>>
>

Mime
View raw message