incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-75) Code improvements in comm layer
Date Fri, 13 Jul 2012 18:09:34 GMT

    [ https://issues.apache.org/jira/browse/S4-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413920#comment-13413920
] 

Karthik Kambatla commented on S4-75:
------------------------------------

I completely agree with your suggestion. Let us push the release with the patch here, but
not forget to fix S4-41 and S4-45 for the next release.
                
> Code improvements in comm layer
> -------------------------------
>
>                 Key: S4-75
>                 URL: https://issues.apache.org/jira/browse/S4-75
>             Project: Apache S4
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Matthieu Morel
>             Fix For: 0.5
>
>         Attachments: 0001-Simplify-TCPEmitter.patch
>
>
> After running into issues related to the comm layer, I took a deeper look and realized
parts of the code are really brittle or simply wrong, in particular in TCPEmitter (e.g. sync
on a Boolean).
> We need a more thorough review of that code so we can improve its robustness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message