incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthieu Morel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-75) Code improvements in comm layer
Date Fri, 13 Jul 2012 17:55:34 GMT

    [ https://issues.apache.org/jira/browse/S4-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413907#comment-13413907
] 

Matthieu Morel commented on S4-75:
----------------------------------

Thanks Karthik for the feedback!

It would be nice indeed to have more guarantees, but as Daniel suggested, the first requirement
for the coming release is that things work as expected under normal conditions.

Performance and optimizations are really tasks that we should leave for a subsequent release.
I will suggest to retarget most related tickets for 0.6, in order to avoid further delay.

So my proposal is to incorporate Daniel's patch, keep working on the release (fixes, docs,
testing), and leave S4-41 and S4-45 for later.

Of course, you may still work on the issues you mentioned, but in that case I think you should
try a different approach, and they probably won't be in the coming release (not a problem).

For info, I just uploaded in branch S4-75 a modification of the producer/consumer test that
usually fails because messages get lost, even though there is no disconnection. When Daniel's
patch is applied, all messages are correctly processed.

                
> Code improvements in comm layer
> -------------------------------
>
>                 Key: S4-75
>                 URL: https://issues.apache.org/jira/browse/S4-75
>             Project: Apache S4
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Matthieu Morel
>             Fix For: 0.5
>
>         Attachments: 0001-Simplify-TCPEmitter.patch
>
>
> After running into issues related to the comm layer, I took a deeper look and realized
parts of the code are really brittle or simply wrong, in particular in TCPEmitter (e.g. sync
on a Boolean).
> We need a more thorough review of that code so we can improve its robustness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message