incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthieu Morel (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-74) NullPointerException on TCPEmitter.onChange()
Date Fri, 13 Jul 2012 14:09:34 GMT

    [ https://issues.apache.org/jira/browse/S4-74?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413766#comment-13413766
] 

Matthieu Morel commented on S4-74:
----------------------------------

Sorry to come back on that one, but I uploaded another commit so that cluster updates are
synchronized, as in other parts of the code (here we have potential concurrent updates between
Zookeeper callbacks and channel connections). Please let me know if that's ok on your side.
                
> NullPointerException on TCPEmitter.onChange() 
> ----------------------------------------------
>
>                 Key: S4-74
>                 URL: https://issues.apache.org/jira/browse/S4-74
>             Project: Apache S4
>          Issue Type: Bug
>    Affects Versions: 0.5
>            Reporter: Daniel Gómez Ferro
>            Assignee: Matthieu Morel
>             Fix For: 0.5
>
>
> TCPEmitter is registering itself as a listener in its constructor: {{this.topology.addListener(this);}}
> The topology is triggering a refresh before the TCPEmitter is fully constructed, so TCPEmitter.partitionNodeMap
is still null during onChange() execution.
> TCPEmitter shouldn't register itself as a listener until it's fully built, see http://www.ibm.com/developerworks/java/library/j-jtp0618/index.html#2
(Don't publish the "this" reference during construction)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message