incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Karthik Kambatla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-75) Code improvements in comm layer
Date Fri, 13 Jul 2012 16:47:33 GMT

    [ https://issues.apache.org/jira/browse/S4-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413865#comment-13413865
] 

Karthik Kambatla commented on S4-75:
------------------------------------

Hi Daniel/Matthieu, 

Firstly, thanks for finding the issues with the TCPEmitter. However, I believe we need to
support guaranteed event delivery with TCP. In the absence of guaranteed delivery, one might
as well use UDP as it is faster. Also, it was this requirement that led to the complication
of TCP code. 

That said, I feel we can take one of the two approaches --
1. Find the issues with S4-7 and fix them; I wonder if we can take any other approach but
maintain message queues for failed deliveries in the presence of network partitions.
2. Push in Daniel's change, and work on S4-41 for guaranteed event delivery. Use Netty with
UDP for performance - S4-45.

I am sorry for not being able to work on the JIRAs assigned to me. Please re-assign if needed.
Meanwhile, I ll try to work on S4-45 over the weekend. 
                
> Code improvements in comm layer
> -------------------------------
>
>                 Key: S4-75
>                 URL: https://issues.apache.org/jira/browse/S4-75
>             Project: Apache S4
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Matthieu Morel
>             Fix For: 0.5
>
>         Attachments: 0001-Simplify-TCPEmitter.patch
>
>
> After running into issues related to the comm layer, I took a deeper look and realized
parts of the code are really brittle or simply wrong, in particular in TCPEmitter (e.g. sync
on a Boolean).
> We need a more thorough review of that code so we can improve its robustness.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message