incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mariano Valles (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-66) S4R packaging: improve app class resolution
Date Fri, 29 Jun 2012 16:00:46 GMT

    [ https://issues.apache.org/jira/browse/S4-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403984#comment-13403984
] 

Mariano Valles commented on S4-66:
----------------------------------

Is the idea to include a simple Java class for parsing? or to use some kind of already made
parser?
(e.g. http://code.google.com/p/javaparser/)

If it's the first one: How can that be better than improving the Groovy function to exclude
comments and corner cases? It would still be parsing the Java source code in any case.
                
> S4R packaging: improve app class resolution
> -------------------------------------------
>
>                 Key: S4-66
>                 URL: https://issues.apache.org/jira/browse/S4-66
>             Project: Apache S4
>          Issue Type: Improvement
>    Affects Versions: 0.5
>            Reporter: Matthieu Morel
>             Fix For: 0.5
>
>
> Currently, when creating an S4R package, the app name added to the manifest is extracted
from the source code through a very brittle process ( see line 152 https://git-wip-us.apache.org/repos/asf?p=incubator-s4.git;a=blob;f=subprojects/s4-tools/src/main/resources/templates/build.gradle;h=a1e50e330c4de47928af38a57da17b050c0c62b5;hb=049a6b00b285039f36c2276079bfc2d037ca856b#l152
)
> We should either use a proper Java class to extract that name, or require the name of
the app class to be passed as a parameter

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message