incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "kishore gopalakrishna (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (S4-33) s4-comm tests should use zookeeper
Date Thu, 22 Dec 2011 01:09:31 GMT

    [ https://issues.apache.org/jira/browse/S4-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174546#comment-13174546
] 

kishore gopalakrishna commented on S4-33:
-----------------------------------------

Karthik,

I think CommTestUtils are in the test package of comm which means these classes dont make
it into s4-comm.jar. So having s4-core depend on s4-comm will not help.

You need to put the comm-test jar in the dependency of s4-core and then use it in test scope.



                
> s4-comm tests should use zookeeper
> ----------------------------------
>
>                 Key: S4-33
>                 URL: https://issues.apache.org/jira/browse/S4-33
>             Project: Apache S4
>          Issue Type: Sub-task
>    Affects Versions: 0.5
>            Reporter: Karthik Kambatla
>             Fix For: 0.5
>
>
> [From Skype call on 12/20] s4-comm tests currently use file-based configurations - AssignmentFromFile,
TopologyFromFile. Instead, they should change to using zookeeper-based configurations.
> Steps involved --
> 1. Move org.apache.s4.fixtures from s4-core/test to s4-comm/test to avoid duplication
of code
> 2. Rewrite s4-comm/tests to use these fixtures.
> Issues --
> 1. s4.fixtures uses some App-related code
> Eager to hear comments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message