incubator-s4-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Flavio Junqueira <...@yahoo-inc.com>
Subject Re: beautiful code
Date Mon, 24 Oct 2011 10:18:51 GMT

On Oct 23, 2011, at 8:07 PM, Matthieu Morel wrote:

>
> Kishore: about findbugs, I also wrote some code that takes advantage  
> of the
> history feature of findbugs so that we can integrate detection of  
> new bugs
> in the continous integration process. Much more efficient than  
> manually
> running the plugin! I can provide that as well.
>
>

Sounds cool, how do you do it exactly, Matthieu?

-Flavio


>
>>
>>
>> On Sun, Oct 23, 2011 at 10:20 AM, Matthieu Morel <mmorel@apache.org>
>> wrote:
>>>>
>>>>
>>>> * Good design will make the code easy to understand but  
>>>> eventually we
>>>> need to implement complex logic. For those cases write very  
>>>> detailed
>>>> comments to help other people read your code.
>>>>
>>>
>>> From the oracle/sun java code conventions (
>>> http://www.oracle.com/technetwork/java/ 
>>> codeconventions-150003.pdf), I
>> like
>>> the following recommendation:
>>>
>>> --> "Note: The frequency of comments sometimes reflects poor  
>>> quality of
>>> code. When you feel compelled to add a comment, consider rewriting  
>>> the
>> code
>>> to make it clearer."
>>
>
> I'm realizing it doesn't read exactly like I intended: this is a  
> comment in
> complement, not in opposition to Leo's suggestion ;-)
>
>
> Matthieu

flavio
junqueira

research scientist

fpj@yahoo-inc.com
direct +34 93-183-8828

avinguda diagonal 177, 8th floor, barcelona, 08018, es
phone (408) 349 3300    fax (408) 349 3301


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message