From rave-dev-return-2459-apmail-incubator-rave-dev-archive=incubator.apache.org@incubator.apache.org Thu Oct 20 14:21:03 2011 Return-Path: X-Original-To: apmail-incubator-rave-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-rave-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AC8D7469 for ; Thu, 20 Oct 2011 14:21:03 +0000 (UTC) Received: (qmail 25420 invoked by uid 500); 20 Oct 2011 14:21:02 -0000 Delivered-To: apmail-incubator-rave-dev-archive@incubator.apache.org Received: (qmail 25391 invoked by uid 500); 20 Oct 2011 14:21:02 -0000 Mailing-List: contact rave-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: rave-dev@incubator.apache.org Delivered-To: mailing list rave-dev@incubator.apache.org Received: (qmail 25380 invoked by uid 99); 20 Oct 2011 14:21:02 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2011 14:21:02 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.215.175] (HELO mail-ey0-f175.google.com) (209.85.215.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Oct 2011 14:20:54 +0000 Received: by eyd9 with SMTP id 9so2847114eyd.6 for ; Thu, 20 Oct 2011 07:20:34 -0700 (PDT) Received: by 10.216.229.87 with SMTP id g65mr2489282weq.73.1319120434389; Thu, 20 Oct 2011 07:20:34 -0700 (PDT) Received: from [10.10.100.141] (oosteinde.castasoftware.com. [81.21.138.121]) by mx.google.com with ESMTPS id fw16sm8139679wbb.13.2011.10.20.07.20.32 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 20 Oct 2011 07:20:32 -0700 (PDT) Message-ID: <4EA02E2F.80409@douma.nu> Date: Thu, 20 Oct 2011 16:20:31 +0200 From: Ate Douma User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110923 Thunderbird/7.0 MIME-Version: 1.0 To: rave-dev@incubator.apache.org Subject: Re: svn commit: r1186573 - /incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp References: <4E9F6C1A.70601@gmail.com> <4E9F73F1.6020109@gmail.com> <4E9FF1B1.1070609@douma.nu> <4EA02107.2040600@gmail.com> In-Reply-To: <4EA02107.2040600@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 10/20/2011 03:24 PM, Hadrian Zbarcea wrote: > Ate, you are right, I know that :). Just to clarify, although I am sure all of > us know this. It's not about good or bad, it's about convention over > configuration and making things simple. META-INF is absolutely necessary, we all > know that. By convention, we'd put it in src/main/resources/META-INF and maven > plugins know what to do with. If we have config like persitence.xml it would go > there. All is fine. What maven does is to generate everything in ./target, and > in that process META-INF gets copied into ./target/classes/META-INF. > > What I was talking about is a few places where META-INF gets created into ./src > somewhere, and it's not a versioned resource, so it should be generated directly > in ./target (instead in ./src and then copied to ./target). I don't know yet if > that was done by mvn or by my eclipse environment. Technically, nothing should > be generated in ./src by the build process, but then again, it's just a > convention. If we add support for OSGi this would become a moot point, the OSGi > manifest would contain a bit more entries. For those less familiar with OSGi, a > bundle is actually a jar with a few extra entries in the MANIFEST.MF, which are > ignored in a servlet container. > > The way I discovered this was by rat:check reporting unknown license for the > generated MANIFEST.MF, rat assumes the convention above. There is another > workaround, of course, excluding the MANIFEST in the rat configuration. > > But it's really not a biggie. I'll give more details once I discover where that > happens. Hi Hadrian, Thanks for the explanation and I fully agree with everything you said. I think I found at least one of the culprits: rave-demo-gadgets/src/main/webapp/META-INF/MANIFEST.MF I suspect this specific instance might be be by-product from the Eclipse WTP plugin, which stupidly assumes and requires "a" MANIFEST.MF to be present, in the src folder, and if not, auto-creates one :( I've long since stopped using Eclipse WTP as I really only encountered problems with it. It also means I can't use WTP server deployment from within Eclipse but for that I'm happy user of Cargo (and command line) instead. +1 for removing the above MANIFEST.MF file. There is no reason for it except to keep Eclipse WTP happy, which is no good reason at all. Thanks, Ate > > Cheers, > Hadrian > > > On 10/20/2011 06:02 AM, Ate Douma wrote: >> On 10/20/2011 03:05 AM, Hadrian Zbarcea wrote: >>> >>> I finally had a bit more time and looked over a few things in rave >>> and it looks mostly good. I ran a rat:check and fixed the only place >>> where a license header was missed. There are a few places where a >>> META-INF directory is created in src (and it shouldn't) and the >>> MANIFEST.MF fails and one pem test file. >>> >>> I intend to look while the META-INF is created in src and fix that and >>> add a configuration for the rat plugin in the main pom to exclude the >>> .pem extension. Any ideas, objections? >> >> No objections for you to look into it. >> >> But I don't see how or why META-INF entries within the src tree by >> definition would be bad. >> AFAIK there are some explicit requirements to do so, like providing the >> OpenJPA persistence.xml which expects it under META-INF. >> And lots of frameworks make use of this for similar purposes and its >> also 'spec' based like for Java Service Providers (under >> META-INF/services/) >> >>> >>> Hadrian >>> >>> >>> >>> On 10/19/2011 08:02 PM, hadrian@apache.org wrote: >>>> Author: hadrian >>>> Date: Thu Oct 20 00:02:15 2011 >>>> New Revision: 1186573 >>>> >>>> URL: http://svn.apache.org/viewvc?rev=1186573&view=rev >>>> Log: >>>> Add missing license header >>>> >>>> Modified: >>>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp >>>> >>>> >>>> >>>> >>>> Modified: >>>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp >>>> >>>> >>>> >>>> URL: >>>> http://svn.apache.org/viewvc/incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp?rev=1186573&r1=1186572&r2=1186573&view=diff >>>> >>>> >>>> >>>> ============================================================================== >>>> >>>> --- >>>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp >>>> >>>> >>>> (original) >>>> +++ >>>> incubator/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/views/error.jsp >>>> >>>> >>>> Thu Oct 20 00:02:15 2011 >>>> @@ -1,3 +1,21 @@ >>>> +<%-- >>>> + Licensed to the Apache Software Foundation (ASF) under one >>>> + or more contributor license agreements. See the NOTICE file >>>> + distributed with this work for additional information >>>> + regarding copyright ownership. The ASF licenses this file >>>> + to you under the Apache License, Version 2.0 (the >>>> + "License"); you may not use this file except in compliance >>>> + with the License. You may obtain a copy of the License at >>>> + >>>> + http://www.apache.org/licenses/LICENSE-2.0 >>>> + >>>> + Unless required by applicable law or agreed to in writing, >>>> + software distributed under the License is distributed on an >>>> + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>>> + KIND, either express or implied. See the License for the >>>> + specific language governing permissions and limitations >>>> + under the License. >>>> + --%> >>>> <%@ page isErrorPage="true" trimDirectiveWhitespaces="true" >>>> pageEncoding="UTF-8" contentType="text/html" %> >>>> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> >>>> <%@ taglib prefix="spring" uri="http://www.springframework.org/tags" %> >>>> @@ -33,4 +51,4 @@ >>>> >>>> >>>> >>>> - >>>> \ No newline at end of file >>>> + >>>> >>>> >>