Return-Path: Delivered-To: apmail-incubator-rat-dev-archive@locus.apache.org Received: (qmail 40439 invoked from network); 12 Mar 2008 22:15:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Mar 2008 22:15:17 -0000 Received: (qmail 3455 invoked by uid 500); 12 Mar 2008 22:15:15 -0000 Delivered-To: apmail-incubator-rat-dev-archive@incubator.apache.org Received: (qmail 3428 invoked by uid 500); 12 Mar 2008 22:15:15 -0000 Mailing-List: contact rat-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: rat-dev@incubator.apache.org Delivered-To: mailing list rat-dev@incubator.apache.org Received: (qmail 3419 invoked by uid 99); 12 Mar 2008 22:15:14 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2008 15:15:14 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of robertburrelldonkin@blueyonder.co.uk designates 195.188.213.5 as permitted sender) Received: from [195.188.213.5] (HELO smtp-out2.blueyonder.co.uk) (195.188.213.5) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Mar 2008 22:14:37 +0000 Received: from [172.23.170.137] (helo=anti-virus01-08) by smtp-out2.blueyonder.co.uk with smtp (Exim 4.52) id 1JZZDj-0007PA-3W for rat-dev@incubator.apache.org; Wed, 12 Mar 2008 22:14:47 +0000 Received: from [82.38.65.6] (helo=[10.0.0.27]) by asmtp-out3.blueyonder.co.uk with esmtpa (Exim 4.52) id 1JZZDi-00037b-G1 for rat-dev@incubator.apache.org; Wed, 12 Mar 2008 22:14:46 +0000 Subject: Import best practice [WAS Re: svn commit: r636144 [2/7] ] From: Robert Burrell Donkin To: rat-dev@incubator.apache.org In-Reply-To: References: <20080311231021.731DB1A983A@eris.apache.org> <3EA4423B-E0A9-4B18-A85B-68AB51868624@SUN.com> <1205352335.10525.1.camel@localhost> Content-Type: text/plain Date: Wed, 12 Mar 2008 22:14:45 +0000 Message-Id: <1205360085.10525.11.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 2008-03-12 at 14:00 -0700, Craig L Russell wrote: > Hi Robert, > > On Mar 12, 2008, at 1:05 PM, Robert Burrell Donkin wrote: > > > > > On Tue, 2008-03-11 at 18:17 -0700, Craig L Russell wrote: > >> Ouch. > >> > >> The license headers are obsolete. Didn't you run RAT on these before > >> checking them in? ;-) > > > > :-) > > > > it was intention. i've always imported then fixed so that the record > > of > > the changes is present in the version control. i'm not sure whether > > the > > consensus is that this is best practice or not. > > Cool. When I imported the JDO stuff from Sun awhile back, I added the > license before checking the files into the Apache repo, so I guess > best practice is undocumented. IIRC there have been a few different theories. the original source covered by the agreement should be a matter of open record. source in apache repositories should have the right headers. JIRA gives an open record so can serve the first purpose. > > i'll post something on general and then write up the results... > > > Might be a good topic for the incubator guides... > > Assuming that there is consensus, of course. even if there isn't consensus, it's useful to establish the pros and cons. - robert