incubator-openmeetings-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maxim Solodovnik <solomax...@gmail.com>
Subject Re: Issue-512
Date Thu, 24 Jan 2013 04:58:28 GMT
OK :) I'll a little bit and will try propose solution fir this :) maybe
common method to change it or something...
On Jan 24, 2013 10:40 AM, "seba.wagner@gmail.com" <seba.wagner@gmail.com>
wrote:

> then you still need to lookup the Client object by its streamid. Which
> means a database request. That is something we don't want. Also the Client
> gets persisted to the database. IClient can't be persisted.
> We could do it the other way round:
> We could add the entire Client object into the IClient.
>
> For example:
> In SessionVariablesUtil.java
> client.setAttribute("rcl", $ourClientFormerlyCalledRoomClient);
>
> and to have the publicSID for a specific IClient we could do something
> like:
> ((Client) client.getAttribute("rcl")).getPublicSID();
>
> The problem will be: The IClient only will hold a reference to a concrete
> _instance_ of the Client object.
> But if you persist the object to the database and do a SELECT statement
> and request that from the database via the EntityManager you may get a
> _new_ instance of that "Client" (so the same ID but another object
> instance).
> So if you do a query like "update client set publicSID = "xyz"" this will
> of course _not_ update the publicSID in the IClient.
> You would still end up with manually updating the attribute in the session
> cache and sync those objects.
>
> You could potentially have a single attribute that way, but I don't think
> that makes it more easy. You have then database objects and somehow link
> some of those instances into a session-cache. I also don't know how OpenJPA
> will handle that.
>
>
> Sebastian
>
>
> 2013/1/24 Maxim Solodovnik <solomax666@gmail.com>
>
>> Maybe we can have reference to IClient inside Client? so all necessary
>> fields can be stored inside IClient, and they will be updated automatically?
>>
>>
>> On Thu, Jan 24, 2013 at 10:22 AM, seba.wagner@gmail.com <
>> seba.wagner@gmail.com> wrote:
>>
>>> I feel this code need to be redesigned :( I don't really like publicSID
>>> stored in 2 places ... too much space for the error :(
>>> => well actually this is exactly what I am doing no, refactor in order
>>> to have the publicSID in two places.
>>> One time in the database/sessionstore second time in the IClient.
>>> If you don't have the information in the IClient you need to access the
>>> full Client-object, which would mean that you need to make a request to the
>>> database. Accessing db objects during sync methods will destroy our
>>> performance.
>>>
>>> Sebastian
>>>
>>>
>>> 2013/1/24 Maxim Solodovnik <solomax666@gmail.com>
>>>
>>>> Thanks for the update.
>>>> I did check all the places publicSID is get changed and seems to fix
>>>> them all.
>>>>
>>>> I feel this code need to be redesigned :( I don't really like publicSID
>>>> stored in 2 places ... too much space for the error :(
>>>>
>>>>
>>>> On Thu, Jan 24, 2013 at 3:20 AM, seba.wagner@gmail.com <
>>>> seba.wagner@gmail.com> wrote:
>>>>
>>>>> What you've fixed Maxim was the method:
>>>>> public synchronized Boolean overwritePublicSID(String
>>>>> newPublicSID)
>>>>> right?
>>>>> That seems to me correct. I am currently not 100% sure if there is
>>>>> another method to be checked.
>>>>> But there is an easy way to check it:
>>>>> When you goto the RoomClient object, highlight the method
>>>>> "setPublicSID" and then press shift+ctrl+g then it should show all code
>>>>> snippets that reference this method ... aka everywhere where the publicSID
>>>>> is set to the RoomClient.
>>>>> And everywhere this publicSID is set, also the IClient needs to be
>>>>> updated using the SessionsVariablesUtil.
>>>>> I think I missed this step for this session attribute.
>>>>>
>>>>> Sebastian
>>>>>
>>>>>
>>>>>
>>>>> 2013/1/22 seba.wagner@gmail.com <seba.wagner@gmail.com>
>>>>>
>>>>> Hi Maxim,
>>>>>>
>>>>>> I will try to look at it asap. I did not expect any issue, I thought
>>>>>> it should have been working just as it did before I added the cluster
>>>>>> specific stuff.
>>>>>>
>>>>>> Sebastian
>>>>>>
>>>>>> 2013/1/22 Maxim Solodovnik <solomax666@gmail.com>
>>>>>>
>>>>>>> Can you please take a look at
>>>>>>> https://issues.apache.org/jira/browse/OPENMEETINGS-512 and my
fix
>>>>>>> for it?
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Jan 22, 2013 at 11:26 AM, seba.wagner@gmail.com <
>>>>>>> seba.wagner@gmail.com> wrote:
>>>>>>>
>>>>>>>> I see currently two main things:
>>>>>>>>  - getting all changes done needed for the clustering + test
them
>>>>>>>>  - create backups of current and previous OpenMeetings versions
and
>>>>>>>> import them (it would be great if the import could be automized
using a
>>>>>>>> JUnit test, so that with any future change when can simply
run the test
>>>>>>>> suite and will see if any backup fails to import)
>>>>>>>>
>>>>>>>> Sebastian
>>>>>>>>
>>>>>>>>
>>>>>>>> 2013/1/22 George Kirkham <gkirkham@co2crc.com.au>
>>>>>>>>
>>>>>>>>> *Please consider:* One feature to include in 2.1 would
be
>>>>>>>>> enabling Adobe’s Acoustic Echo Cancelling (AEC).****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> We have tested this, and it greatly improves end user
experience
>>>>>>>>> for meetings (for people whose computers do not support
hardware AEC).
>>>>>>>>> ****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> Thanks,****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> George Kirkham****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> *From:* seba.wagner@gmail.com [mailto:seba.wagner@gmail.com]
>>>>>>>>> *Sent:* Tuesday, 22 January 2013 8:24 AM
>>>>>>>>> *To:* openmeetings-user@incubator.apache.org
>>>>>>>>> *Subject:* Re: some questions to recordings and different
>>>>>>>>> moodle-sites****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> Regarding releasing, I think a first step towards that
would be to
>>>>>>>>> decide on a release manager and about the features that
need to be
>>>>>>>>> completed for 2.1. I guess we all have a rough idea about
what should go
>>>>>>>>> into v2.1 but no concrete consens was made yet IMHO.****
>>>>>>>>>
>>>>>>>>> Sebastian****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> 2013/1/22 Maxim Solodovnik <solomax666@gmail.com>****
>>>>>>>>>
>>>>>>>>> lots of questions :)****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> 1) openmeetingsModuleKey should be used to separate users/files
of
>>>>>>>>> multiple CMS connected to one openmeetings (multiple
moodles in your case)
>>>>>>>>> ****
>>>>>>>>>
>>>>>>>>> 2) sure you can manage the recordings it is located at
>>>>>>>>> OM_HOME/webapps/openmeetings/streams/hibernate/****
>>>>>>>>>
>>>>>>>>> 3) The id in the streams folder id DB id of the recording****
>>>>>>>>>
>>>>>>>>> 4) openmeetingsModuleKey acts as "external user type"
this is by
>>>>>>>>> design made to separate users from multiple CMSes****
>>>>>>>>>
>>>>>>>>> 5) this part is tricky, you can use OM system export/import,
but
>>>>>>>>> in your case this will create dublicate users/groups/rooms
(most probably)
>>>>>>>>> and there is no "automatic way" to handle this mess.****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> I hope we will have release soon, but this question is
for
>>>>>>>>> Sebastian****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> On Mon, Jan 21, 2013 at 10:08 PM, <michael.wuttke@eledia.de>
>>>>>>>>> wrote:****
>>>>>>>>>
>>>>>>>>> Hello,
>>>>>>>>>
>>>>>>>>> I've some questions about openmeetings in connection
with different
>>>>>>>>> moodle-installations. I have installations of openmeetings
(1.8,
>>>>>>>>> 1.9 and
>>>>>>>>> 2.0) for different moodle-sites. Particularly I am interested
in
>>>>>>>>> how to
>>>>>>>>> manage conference-recordings of openmeetings. The goal
is to have
>>>>>>>>> one
>>>>>>>>> openmeetings installation (2.+) for different moodle-sites.
My
>>>>>>>>> specific
>>>>>>>>> questions are:
>>>>>>>>>
>>>>>>>>> 1. What can I do, to see as an moodle-teacher only the
recordings
>>>>>>>>> I've
>>>>>>>>> made? The openmeetingsModuleKey seems to have no effect.
>>>>>>>>> 2. How are the recordings playable offline? Is it possible
to
>>>>>>>>> manage (to
>>>>>>>>> export or to delete) these recordings directly with in
>>>>>>>>> openmeetings?
>>>>>>>>> 3. How or where can I find the recordings? What means
in that case
>>>>>>>>> the ID
>>>>>>>>> in the ./streams folder?
>>>>>>>>> 4. Can moodle users and moodle courses be assigned to
certain
>>>>>>>>> organizations by the webservice? How can the user groups
from
>>>>>>>>> various
>>>>>>>>> moodle systems be managed in openmeetings?
>>>>>>>>> 5. How can I migrate (export and import) recordings from
old
>>>>>>>>> existing
>>>>>>>>> openmeetings installations (1.8 and 1.9) to a new clean
2.0
>>>>>>>>> openmeetings
>>>>>>>>> installation?
>>>>>>>>>
>>>>>>>>> And last but not least:
>>>>>>>>> When will the next version of openmeetings (2.1) expected?
>>>>>>>>>
>>>>>>>>> Thank you for your help,
>>>>>>>>> Michael****
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> ****
>>>>>>>>>
>>>>>>>>> ** **
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> WBR
>>>>>>>>> Maxim aka solomax ****
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Sebastian Wagner
>>>>>>>>> https://twitter.com/#!/dead_lock
>>>>>>>>> http://www.webbase-design.de
>>>>>>>>> http://www.wagner-sebastian.com
>>>>>>>>> seba.wagner@gmail.com ****
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Sebastian Wagner
>>>>>>>> https://twitter.com/#!/dead_lock
>>>>>>>> http://www.webbase-design.de
>>>>>>>> http://www.wagner-sebastian.com
>>>>>>>> seba.wagner@gmail.com
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> WBR
>>>>>>> Maxim aka solomax
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sebastian Wagner
>>>>>> https://twitter.com/#!/dead_lock
>>>>>> http://www.webbase-design.de
>>>>>> http://www.wagner-sebastian.com
>>>>>> seba.wagner@gmail.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Sebastian Wagner
>>>>> https://twitter.com/#!/dead_lock
>>>>> http://www.webbase-design.de
>>>>> http://www.wagner-sebastian.com
>>>>> seba.wagner@gmail.com
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> WBR
>>>> Maxim aka solomax
>>>>
>>>
>>>
>>>
>>> --
>>> Sebastian Wagner
>>> https://twitter.com/#!/dead_lock
>>> http://www.webbase-design.de
>>> http://www.wagner-sebastian.com
>>> seba.wagner@gmail.com
>>>
>>
>>
>>
>> --
>> WBR
>> Maxim aka solomax
>>
>
>
>
> --
> Sebastian Wagner
> https://twitter.com/#!/dead_lock
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wagner@gmail.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message