Mailing-List: contact openmeetings-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: openmeetings-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of seba.wagner@gmail.com
 designates 209.85.216.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CACeMiA8yPSFPYSubf5sC_ibwmAfy81cqMzabVxTGeZ+OPFKuww@mail.gmail.com>
References: 
 <CACeMiA9dur2OxudMYbP6d14186BHcQAvNy12pzWcFBEQtN50-Q@mail.gmail.com>
 <CAGc_3jEY+Wg5xpE+3T0kMmDqrF-qpMui3bAjtbJBecwKu0F5WA@mail.gmail.com>
 <CADN_ye+1-nc-TVpeKv9xMhVQV=zVH_aXM+k2hVh4qoXBKnaFSQ@mail.gmail.com>
 <CACeMiA8yPSFPYSubf5sC_ibwmAfy81cqMzabVxTGeZ+OPFKuww@mail.gmail.com>
From: "seba.wagner@gmail.com" <seba.wagner@gmail.com>
Date: Sun, 30 Dec 2012 14:21:53 +1300
Message-ID: 
 <CACeMiA9y9fw5W5xweOeMY6StXXggHSF4M8LjC_fhLFFcsmC7ZQ@mail.gmail.com>
Subject: Re: some issue with the chat panel and the fontsize
To: "openmeetings-dev@incubator.apache.org"
 <openmeetings-dev@incubator.apache.org>
Content-Type: multipart/alternative; boundary=047d7bea3b4412cb8d04d207bac2

--047d7bea3b4412cb8d04d207bac2
Content-Type: text/plain; charset=KOI8-R
Content-Transfer-Encoding: quoted-printable

Hi Artyom,

your patches fit nicely :)
I have done only a few cosmetic changes. And you've forgotten to rename the
button in the overallChatTabBottom.lzx class. However, I like it!

Sebastian


2012/12/30 seba.wagner@gmail.com <seba.wagner@gmail.com>

> Hi Artyom,
>
> thanks for the patches!
> I will review and commit the changes.
>
> Sebastian
>
>
> 2012/12/30 Artyom Horuzhenko <akhor666@gmail.com>
>
>> Hello Sebastian!
>> These changes are mine. Thank you for the detailed explanation and
>> recomendations. I fixed all my issues, you could find a patch here:
>> https://issues.apache.org/jira/browse/OPENMEETINGS-228. Also I found a
>> lot of icons without license information (added before my changes).
>>
>> 2012/12/27 Alexei Fedotov <alexei.fedotov@gmail.com>:
>> > Hello Sebastian,
>> > Happy Christmas! :-)
>> >
>> > Thanks for good questions, I'm looking into this.
>> >
>> > --
>> > With best regards / =D3 =CE=C1=C9=CC=D5=DE=DB=C9=CD=C9 =D0=CF=D6=C5=CC=
=C1=CE=C9=D1=CD=C9,
>> > Alexei Fedotov / =E1=CC=C5=CB=D3=C5=CA =E6=C5=C4=CF=D4=CF=D7,
>> > http://dataved.ru/
>> > +7 916 562 8095
>> >
>> >
>> > On Thu, Dec 27, 2012 at 3:04 AM, seba.wagner@gmail.com
>> > <seba.wagner@gmail.com> wrote:
>> >> Hi Alexei,
>> >>
>> >> Happy Christmas :) I hope you had some nice holidays!
>> >>
>> >> I have some questions regarding the code for the font sizes.
>> >>
>> >> The icon that you are using, we should not include the icons and
>> compile
>> >> it
>> >> into the application. We have a theme XML file.
>> >>
>> >> Have a look in chatTabBottom.lzx Line 173:
>> >> <miniIconsImage src=3D"$once{ canvas.getThemeImage('button_cancel_rsc=
')
>> }"
>> >>
>> >> button_cancel_rsc is the name of the ressource configured in the
>> >> default-theme.xml file.
>> >>
>> >> Also we need to make sure that all our icons are compatible with the
>> APL.
>> >> Where did you copy the font.png from, what License is it?
>> >> I see that there are some other icons in the file:
>> >> WebContent/src/modules/conference/tabcontent/chat/library.lzx that ha=
ve
>> >> no
>> >> License.
>> >> I guess some of them are not even in use and can be deleted.
>> >> However every icon that we include needs a proper documentation where
>> it
>> >> has
>> >> been copied from.
>> >> See for example:
>> >> WebContent/src/modules/conference/tabcontent/library.lzx:
>> >>
>> >>     <!-- FamFam Icon Set -->
>> >>     <resource name=3D"messagebox_info_rsc"
>> src=3D"resources/information.png"
>> >> />
>> >>
>> >> The comment tells anybody that we have taken that icon from the FamFa=
m
>> >> Icon
>> >> set. And in our NOTICE file we have this comment:
>> >>
>> >> This product includes icons from FamFamFam Icon Set Silk.
>> >> http://www.famfamfam.com/lab/icons/silk/
>> >>
>> >> The comment links to the NOTICE, and in that sense we have the correc=
t
>> >> attribution of the Icon done.
>> >> However for those font size icons there is no attribution at all. We
>> >> can't
>> >> release that.
>> >>
>> >> Also the icons itself look not sharp, the reason is that you are
>> >> stretching
>> >> them. Is there a reason for stretching the icons? If there is no real
>> >> need
>> >> for a stretch then it would look much better if you would use the ico=
ns
>> >> in
>> >> its original size and modify the surrounding box to match the icons,
>> >> instead
>> >> of stretching every icon to fit into your box (or you look for icons
>> that
>> >> have the needed 24x24 size). The icons you are using are 16x16 so you
>> >> should
>> >> actually use that for the UI also.
>> >>
>> >> Sebastian
>> >> --
>> >> Sebastian Wagner
>> >> https://twitter.com/#!/dead_lock
>> >> http://www.webbase-design.de
>> >> http://www.wagner-sebastian.com
>> >> seba.wagner@gmail.com
>>
>
>
>
> --
> Sebastian Wagner
> https://twitter.com/#!/dead_lock
> http://www.webbase-design.de
> http://www.wagner-sebastian.com
> seba.wagner@gmail.com
>


--=20
Sebastian Wagner
https://twitter.com/#!/dead_lock
http://www.webbase-design.de
http://www.wagner-sebastian.com
seba.wagner@gmail.com

--047d7bea3b4412cb8d04d207bac2--