incubator-oozie-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (OOZIE-673) offset and len options not working as expected
Date Thu, 02 Feb 2012 20:32:57 GMT

    [ https://issues.apache.org/jira/browse/OOZIE-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199192#comment-13199192
] 

jiraposter@reviews.apache.org commented on OOZIE-673:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3738/#review4774
-----------------------------------------------------------


Looks good.

 A 10000 resultset by default means a large DB result, caching locally in the server (because
the JSON structure is built in memory) and then network traffic.

Still, I'd argue a more sensible default is 1000. I don't see how this will break the client
as it is a just a different number of rows being returned.




- Alejandro


On 2012-02-02 20:00:50, Virag Kothari wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3738/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-02 20:00:50)
bq.  
bq.  
bq.  Review request for oozie.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  https://issues.apache.org/jira/browse/OOZIE-673
bq.  
bq.  
bq.  This addresses bug oozie-673.
bq.      https://issues.apache.org/jira/browse/oozie-673
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 1239737 
bq.    trunk/core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java 1239737

bq.    trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java
1239737 
bq.    trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 1239737 
bq.    trunk/core/src/main/resources/oozie-default.xml 1239737 
bq.    trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java
1239737 
bq.    trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1239737 
bq.  
bq.  Diff: https://reviews.apache.org/r/3738/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  test for sorting added
bq.  tested after running cron example
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Virag
bq.  
bq.


                
> offset and len options not working as expected
> ----------------------------------------------
>
>                 Key: OOZIE-673
>                 URL: https://issues.apache.org/jira/browse/OOZIE-673
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Virag Kothari
>
> oozie job -info 0022981-111110182218199-oozie-wrkf-C -offset 3
> ID                                         Status    Ext ID                         
     Err Code  Created         
> Nominal Time
> 0022981-111110182218199-oozie-wrkf-C@1     SUCCEEDED 0022982-111110182218199-oozie-wrkf-W
-         2012-01-16 06:24
> 2010-01-01 00:00
> ------------------------------------------------------------------------------------------------------------------------------------
> 0022981-111110182218199-oozie-wrkf-C@4     SUCCEEDED 0022985-111110182218199-oozie-wrkf-W
-         2012-01-16 06:24
> 2010-01-01 00:30
> ------------------------------------------------------------------------------------------------------------------------------------
> 0022981-111110182218199-oozie-wrkf-C@5     SUCCEEDED 0022986-111110182218199-oozie-wrkf-W
-         2012-01-16 06:24
> 2010-01-01 00:40
> ------------------------------------------------------------------------------------------------------------------------------------
> The jira proposes to order actions by nominal time
> Also, the info command may timeout if the number of coordinator actions are very high.
So, the default number of actions to retrieve while using the info should be oozie-site configurable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message