incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 120957] Export should give same gradient for small step counts as shape in edit mode
Date Mon, 01 Oct 2012 12:20:41 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=120957

Armin Le Grand <Armin.Le.Grand@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ACCEPTED
                 CC|                            |Armin.Le.Grand@me.com
     Ever confirmed|0                           |1

--- Comment #4 from Armin Le Grand <Armin.Le.Grand@me.com> ---
ALG: Checked all local cases (AA and no-AA edit view rendering. Checking all
mentioned cases:

(a) Copy the shape, insert it and convert it to metafile. OK?

ImplDrawLinearGradient/ImplDrawComplexGradient not used

(b) Copy the shape, insert it and convert it to bitmap. OK? (The missing 1
pixel right and 1 pixel bottom occurs with other fillings too.)

ImplDrawLinearGradient/ImplDrawComplexGradient not used

(c) Switch to presentation mode. OK? (The white lines between the steps are a
problem of the presentation mode and occur in the same way using other gradient
styles like rectangle.)

OutputDevice::AddGradientActions is used from the current SlideShow mechanism;
the polygons get recorded to a metafile

(d) Export whole slide to pdf. Open in pdf-reader. OK?

OutputDevice::AddGradientActions is used from PDFWriterImpl::implWriteGradient;
the polygons get recorded to a metafile

(e) Export whole slide to flash. Open in browser. OK?

OutputDevice::AddGradientActions is used from
swf::Writer::Impl_writeGradientEx; the polygons get recorded to a metafile

(f) Export only shape to pure bitmap. Open with picture application. OK?

OutputDevice::ImplDrawLinearGradient is used directly from
OutputDevice::DrawGradient; no metafile recording

(g) Export only shape to wmf. Open with picture application. OK?

OutputDevice::AddGradientActions is used from tools, metafile is recorded

(h) Print slide. OK?

MetaGradientAction::Execute calls OutputDevice::ImplDrawLinearGradient, no
metafile recording

Thus, we have:
- no use of old paints (a,b)
- metafile recording (c,d,e,g)
- direct paint (f,h)

no use of old paints: because the metainfo is used, recorded in the
MetaCommentAction 'hacks'.

For the other two I'm thinking about using primitive functionality inside of
ImplDrawLinearGradient/ImplDrawComplexGradient to ensure same looking and
colors...

P.S.: No doubt, changing the old code is an option, but how safe is it? I know
why I am soo careful with touching that old code, it's more than bad readable
and does not offer an easy overview.
Looking further...

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message