Return-Path: X-Original-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A48B6DF34 for ; Wed, 5 Sep 2012 14:58:32 +0000 (UTC) Received: (qmail 82468 invoked by uid 500); 5 Sep 2012 14:58:32 -0000 Delivered-To: apmail-incubator-ooo-issues-archive@incubator.apache.org Received: (qmail 82416 invoked by uid 500); 5 Sep 2012 14:58:32 -0000 Mailing-List: contact ooo-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-issues@incubator.apache.org Delivered-To: mailing list ooo-issues@incubator.apache.org Received: (qmail 82408 invoked by uid 99); 5 Sep 2012 14:58:32 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2012 14:58:32 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.123] (HELO sif.zones.apache.org) (140.211.11.123) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Sep 2012 14:58:31 +0000 Received: by sif.zones.apache.org (Postfix, from userid 80) id 69F10749D; Wed, 5 Sep 2012 14:58:11 +0000 (UTC) From: bugzilla@apache.org To: ooo-issues@incubator.apache.org Subject: [Bug 120824] Save performance: Improve StyleSheet mapping Date: Wed, 05 Sep 2012 14:58:10 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: spreadsheet X-Bugzilla-Component: save-export X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: Armin.Le.Grand@me.com X-Bugzilla-Status: ACCEPTED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ooo-issues@incubator.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/ooo/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/ooo/show_bug.cgi?id=120824 --- Comment #3 from Armin Le Grand --- ALG: Another bottleneck is ScStyleObj::SetOnePropertyValue because for every single property change a StyleSheetChange update is triggered. Since this update is independent from the property it can be optimized to do that after a range of properties is set. Added ScStyleObj::SetOnePropertyValueWithoutUpdate, made ScStyleObj::SetOnePropertyValue use it and call StyleSheetChangedUpdate() (also added and extracted from ScStyleObj::SetOnePropertyValue. Using in ScStyleObj::setPropertyValues to set all props in a loop and call update only once. -- You are receiving this mail because: You are the assignee for the bug.