incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [Bug 120832] Test for bug 120578: some of the font color is not correct
Date Thu, 06 Sep 2012 08:54:37 GMT

bjcheny <> changed:

           What    |Removed                     |Added
  Attachment #79319|                            |review?
              Flags|                            |

--- Comment #3 from bjcheny <> ---
Created attachment 79319
patch for font color in table

Both table style and color you set in table will affect last font color for
text in table. In this sample, the color set manually should have higher
priority than that from table style.

The patch involves:
1. In unotext.cxx::lcl_ApplyCellProperties(), when the char color fails to be
set on cell object, it will throw an exception. When the exception is caught,
we should check whether the char color is already existing or not, instead of
replacing it directly. Because if the color is already existing, it means color
comes from manually customization.
2. In DomainMapper.cxx, the table style's text properties will go to table's
properties in DomainMapperTableHandler::endTableGetTableStyle(). Thus, it
shouldn't  be merged here. Otherwise, it will be considered as those set
manually, and confuses logic mentioned above.

You are receiving this mail because:
You are the assignee for the bug.

View raw message