incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 119795] Table style does not import correctly when open pptx file in AOO.
Date Tue, 21 Aug 2012 07:57:34 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=119795

--- Comment #5 from Yolanda Zhang Ying <tldyzem@gmail.com> ---
After further review and verify, some problems need to be clarified:

1> We need more information on the problem description on the user scenario to
make such file, and also the solution description, and UT coverage;

2> From the solution, it seems that just only fix the fill color for last row
and last column, so it's a partial fix, isn't it?

3> Below code has unclear definition, and just for this fix, it does not make
sense to put it into base, except it's for whole logic to do it like this:
\oox\source\drawingml\fillproperties.cxx
if( maFillColor.isUsed() )
                {
                                      //This part is specify for this fix, not
for correct logic for this part, need to give more explanation for the
necessary. And what does bTransformed mean?
                    if( bTransformed )
                        rPropMap.setProperty( SHAPEPROP_FillColor,
maFillColor.getColor( rGraphicHelper, nPhClr ) );
                    else
                        rPropMap.setProperty( SHAPEPROP_FillColor,
maFillColor.getSchemeColor( rGraphicHelper) );

                }

4> The code below is special for fill property set for specific table cells,
suggest to consider the logic for this part that, we need to calculate the
target styles, which including: font style and table style, in the function,
and push it as a result into the PropertyMap:

\oox\source\drawingml\table\tablecell.cxx
if ( rProperties.isLastRow() && ( nRow == nMaxRow -1 ) )
    {
        ... ...
                //This part aim to put the cell fill properties into
PropertyMap, but I think it should calculate the fill properties according to
the cell's characteristic as a result of aFillProperties, and push into
PropertyMap at last. So it's more clearly that how could we decide the
properties in the whole logic.
        aFillProperties.assignUsed( maFillProperties );
        aFillProperties.pushToPropMap( aPropMap,
rFilterBase.getGraphicHelper(), false ); 
        bPropPushed =true;
    }

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message