incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 119607] [From Symphony] Text font spacing in comments doesn't expand/condense by the expected value
Date Thu, 30 Aug 2012 02:16:05 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=119607

Yolanda Zhang Ying <tldyzem@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tldyzem@gmail.com

--- Comment #5 from Yolanda Zhang Ying <tldyzem@gmail.com> ---
(In reply to comment #4)
> This solution isn't good enough. Working on a better one.
> 
> (In reply to comment #3)
> > Created attachment 79175 [details]
> > patch for font spacing in comments for docx
> > 
> > The font spacing in comments is calculated in different way from that out of
> > comments.
> > 
> > Thus, the patch includes below changes:
> > 1. add related token id in model.xml to ensure comments will be detected
> > 2. add a flag to indicate whether the font spacing is for comments or not.

Yes, aggree.
It's not so good to justify the properties by add the special flag for detect
of in-comments or not, because for docx import, the import filter work as state
machine, and the state will be chaos if we add more and more special flag.
I think better way is to separate the properties for different use scenario by
definition through parent-child relationship in OOXML.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message