Return-Path: X-Original-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B8B81D165 for ; Sun, 22 Jul 2012 13:23:37 +0000 (UTC) Received: (qmail 85487 invoked by uid 500); 22 Jul 2012 13:23:37 -0000 Delivered-To: apmail-incubator-ooo-issues-archive@incubator.apache.org Received: (qmail 85389 invoked by uid 500); 22 Jul 2012 13:23:36 -0000 Mailing-List: contact ooo-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-issues@incubator.apache.org Delivered-To: mailing list ooo-issues@incubator.apache.org Received: (qmail 85332 invoked by uid 99); 22 Jul 2012 13:23:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jul 2012 13:23:33 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.123] (HELO sif.zones.apache.org) (140.211.11.123) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jul 2012 13:23:32 +0000 Received: by sif.zones.apache.org (Postfix, from userid 80) id CA14243D7; Sun, 22 Jul 2012 13:23:12 +0000 (UTC) From: bugzilla@apache.org To: ooo-issues@incubator.apache.org Subject: [Bug 120341] New: Rework SCSTR_FIELDSEP so that is is less error-prone Date: Sun, 22 Jul 2012 13:23:11 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: spreadsheet X-Bugzilla-Component: save-export X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: pescetti@apache.org X-Bugzilla-Status: CONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ooo-issues@incubator.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: priority bug_id assigned_to short_desc bug_severity cf_bug_type classification op_sys reporter rep_platform bug_status version component product Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/ooo/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/ooo/show_bug.cgi?id=120341 Priority: P3 Bug ID: 120341 Assignee: ooo-issues@incubator.apache.org Summary: Rework SCSTR_FIELDSEP so that is is less error-prone Severity: normal Issue Type: ENHANCEMENT Classification: Application OS: All Reporter: pescetti@apache.org Hardware: All Status: CONFIRMED Version: AOO 3.4.0 Component: save-export Product: spreadsheet As discussed by Ariel in http://s.apache.org/rMk : In main/sc/source/ui/src/scstring.src#483 483 String SCSTR_FIELDSEP 484 { 485 Text [ en-US ] = ",\t44\t;\t59\t:\t58\t{Tab}\t9\t{space}\t32 " ; 486 }; It would be better to place markers, remove the localization, and replace the markers (I guess "Tab" and "space" are already translated somewhere else, or two new string can be created): String SCSTR_FIELDSEP { Text = ",\t44\t;\t59\t:\t58\t{$1}\t9\t{$2}\t32 " ; }; String SCSTR_FIELDSEP_TAB { Text [ en-US ] = "Tab" ; }; String SCSTR_FIELDSEP_SPACE { Text [ en-US ] = "space" ; }; If someone files a new bug, I [Ariel] can take a look at it. Note: Bug 120216 is the problem that started this (more general) discussion. -- You are receiving this mail because: You are the assignee for the bug.