incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 119592] [From Symphony] The left-style columns display with the same width when opening with AOO
Date Tue, 10 Jul 2012 15:20:58 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=119592

Andre <af@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |af@a-w-f.de
     Ever confirmed|0                           |1

--- Comment #4 from Andre <af@a-w-f.de> ---
I am not really familiar with Writer code but it looks like m_nColumnCount is
off by one by design, indicated by loops like

    for( sal_Int32 nCol = 0; nCol <= m_nColumnCount; ++nCol)
        ...

With that in mind I understand the patch, but the original code looks like an
error, ie the comparison

    if ( ... sal_Int32(m_aColDistance.size()) == m_nColumnCount) ...)

looks like it should be

    if ( ... sal_Int32(m_aColDistance.size()) == m_nColumnCount+1) ...)

which is basically what the patch does.

My question is this: why not remove the 

    sal_Int32(m_aColDistance.size()) == m_nColumnCount)

part from the if-statement?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message