incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 119480] [From Symphony]Curve in Background cannot be displayed correctly in AOO3.4
Date Fri, 06 Jul 2012 14:53:57 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=119480

Andre <af@a-w-f.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |af@a-w-f.de

--- Comment #8 from Andre <af@a-w-f.de> ---
Your patch looks basically good.

But I still have two questions:

- Regarding the use of atan() on line 4558:
  What do you thing about using atan2() instead?  That would allow detection of
the right quadrant.

- Regarding the call of NormAngle360() on line 4559:
  NormAngle360() seems to expect arguments that are given as angle, measured in
degree*100 (in the range [0,36000) for a full circle).
  In the patch, however, the argument is the result of atan()*100.  Atan()
returns a value in radian (range [-pi/2,+pi/2]).
  Is there a transformation factor missing (radian to degree) or am I missing
something?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message