Return-Path: X-Original-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D078FDDCA for ; Wed, 20 Jun 2012 01:30:42 +0000 (UTC) Received: (qmail 31233 invoked by uid 500); 20 Jun 2012 01:30:42 -0000 Delivered-To: apmail-incubator-ooo-issues-archive@incubator.apache.org Received: (qmail 31198 invoked by uid 500); 20 Jun 2012 01:30:42 -0000 Mailing-List: contact ooo-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-issues@incubator.apache.org Delivered-To: mailing list ooo-issues@incubator.apache.org Received: (qmail 31189 invoked by uid 99); 20 Jun 2012 01:30:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 01:30:42 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.123] (HELO sif.zones.apache.org) (140.211.11.123) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2012 01:30:41 +0000 Received: by sif.zones.apache.org (Postfix, from userid 80) id C298F469A; Wed, 20 Jun 2012 01:30:21 +0000 (UTC) From: bugzilla@apache.org To: ooo-issues@incubator.apache.org Subject: [Bug 120015] Application crash when undo "Graphic styles" action. Date: Wed, 20 Jun 2012 01:30:20 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: presentation X-Bugzilla-Component: formatting X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jiazema@gmail.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ooo-issues@incubator.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/ooo/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/ooo/show_bug.cgi?id=120015 --- Comment #8 from Ma Bingbing --- (In reply to comment #2) > ALG: Shouldnt the deletion of the Style also create a undo action, so that > the stack is complete and undoing would first restore the style, then reset > the style at the SdrObject. I thik it is an error that no undo action gets > created for deletingthe StyleSheet. Thanks for you suggestion. It is a better solution and I am agree with you. I have some questions about adding undo action for deleting StyleSheet. 1. If the "Style list" isn't closed, the undo action just re-add the style sheet to "Style sheet", it is all right. 2. If the "Style list" is closed, we may have some choices: a. open the "Style list " dialog and re-add the style sheet b. re-add the style sheet and show nothing in the UI c. re-add the style sheet and reset the style at the SdrObject Do you have any ideas about them? Thanks! -- You are receiving this mail because: You are the assignee for the bug.