Return-Path: X-Original-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 392859555 for ; Mon, 25 Jun 2012 11:33:46 +0000 (UTC) Received: (qmail 38357 invoked by uid 500); 25 Jun 2012 11:33:46 -0000 Delivered-To: apmail-incubator-ooo-issues-archive@incubator.apache.org Received: (qmail 38257 invoked by uid 500); 25 Jun 2012 11:33:45 -0000 Mailing-List: contact ooo-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-issues@incubator.apache.org Delivered-To: mailing list ooo-issues@incubator.apache.org Received: (qmail 38236 invoked by uid 99); 25 Jun 2012 11:33:45 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2012 11:33:45 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.123] (HELO sif.zones.apache.org) (140.211.11.123) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2012 11:33:40 +0000 Received: by sif.zones.apache.org (Postfix, from userid 80) id A15344974; Mon, 25 Jun 2012 11:33:20 +0000 (UTC) From: bugzilla@apache.org To: ooo-issues@incubator.apache.org Subject: [Bug 119989] [From Symphony]Pie chart height becomes greater when open Excel file Date: Mon, 25 Jun 2012 11:33:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: chart X-Bugzilla-Component: open-import X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: Armin.Le.Grand@me.com X-Bugzilla-Status: CONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: ooo-issues@incubator.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/ooo/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/ooo/show_bug.cgi?id=119989 --- Comment #17 from Armin Le Grand --- ALG: Hi Tan Li, thanks for the answer. I hope I have not interrupted your traditional holiday; holiday is holiday, no need to break it :-) I see your point, but still, is "IsExcel3DChart" needed? - "3DHeight" is a new API value, it does not exist before this proposed change - If it did not exist, it is not used yet, so if defining there is free choice how to define it - If true == IsExcel3DChart, 3DHeight is a relative value, applied to getTransformedDepth in the implementation - if false == IsExcel3DChart, getTransformedDepth is used directly, a evtl. set value of "3DHeight" is ignored. Noone is setting "3DHeight" up to today. Why not: - define property "3DRelativeHeight" instead of "3DHeight", default 100%, "Defines the Height of a pie segment relative to it's pedefined height" - No need to define "IsExcel3DChart" at all - In all cases, use getTransformedDepth and relative height value - With default, old behaviour will use 100% of getTransformedDepth, no change - With value set, new behaviour will work as needed Thus, "IsExcel3DChart" is not needed and the API stays minimal, only one more value needs to be added. The value in question (3DHeight) is a relative definition anyways, why not call it so and use/add it as such? Thanks in advance! -- You are receiving this mail because: You are the assignee for the bug.