Return-Path: X-Original-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Delivered-To: apmail-incubator-ooo-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7E9189ED8 for ; Thu, 7 Jun 2012 06:37:39 +0000 (UTC) Received: (qmail 1744 invoked by uid 500); 7 Jun 2012 06:37:38 -0000 Delivered-To: apmail-incubator-ooo-issues-archive@incubator.apache.org Received: (qmail 1636 invoked by uid 500); 7 Jun 2012 06:37:37 -0000 Mailing-List: contact ooo-issues-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: ooo-issues@incubator.apache.org Delivered-To: mailing list ooo-issues@incubator.apache.org Received: (qmail 1604 invoked by uid 99); 7 Jun 2012 06:37:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2012 06:37:36 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.123] (HELO sif.zones.apache.org) (140.211.11.123) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Jun 2012 06:37:35 +0000 Received: by sif.zones.apache.org (Postfix, from userid 80) id E1F474450; Thu, 7 Jun 2012 06:37:14 +0000 (UTC) From: bugzilla@apache.org To: ooo-issues@incubator.apache.org Subject: [Bug 118906] Support system libraries for apr, apr-util, serf, coinmp. Date: Thu, 07 Jun 2012 06:37:12 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: external prerequisites X-Bugzilla-Component: www X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: af@a-w-f.de X-Bugzilla-Status: CONFIRMED X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: af@a-w-f.de X-Bugzilla-Target-Milestone: not determined X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/ooo/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/ooo/show_bug.cgi?id=118906 --- Comment #4 from Andre --- If I read the rebase.pl in the same directory as coffbase.txt correctly, then all DLLs that are not explicitly mentioned in coffbase.txt (or no_rebase.txt) then the address is calculated automatically. The fixed addresses in coffbase.txt are only important for binary patches to installed releases, which we do not have anymore. For creating a full installation set, the fixed addresses are not necessary. I also looked at your patch. Looks good. Just one question and one remark: Q: In the changes to configure.in I saw the lines # some systems need this. Like Ubuntu.... AC_CHECK_LIB(m, floor) AC_CHECK_LIB(dl, dlopen) Can you explain why that is necessary? And, do we need them in other places, too? R: Maybe you can add a guard to the makefile of coinmp that excludes building the external library when system CoinMP is used. That should not be strictly necessary (with adding COINMP only conditionally to BUILD_TYPE) but we have these guards in other modules. -- You are receiving this mail because: You are on the CC list for the bug.