incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 120040] There is a memory leak in function SvBaseLink::~SvBaseLink()
Date Wed, 20 Jun 2012 14:14:09 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=120040

Armin Le Grand <Armin.Le.Grand@me.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Armin.Le.Grand@me.com

--- Comment #3 from Armin Le Grand <Armin.Le.Grand@me.com> ---
ALG: SvBaseLink has three constructors, and only in two of them pImpl gets
allocated and thus initialized. Thus, in the 3rd constructor, pImpl will point
to a random address. Freeing it in the destructor could crash the office.

A minimal fix would have to init pImpl to zero and check before construction.
But even then, the implementation makes use of pImpl without tests, so maybe in
the 3rd constructor it should also be allocated. All in all, the whole class
would need more rework, all members initialized in all constructors, and pImpl
decided for 3rd constructor.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
View raw message