incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 118906] Support system libraries for apr, apr-util, serf, coinmp.
Date Thu, 07 Jun 2012 06:37:12 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=118906

--- Comment #4 from Andre <af@a-w-f.de> ---
If I read the rebase.pl in the same directory as coffbase.txt correctly, then
all DLLs that are not explicitly mentioned in coffbase.txt (or no_rebase.txt)
then the address is calculated automatically.  The fixed addresses in
coffbase.txt are only important for binary patches to installed releases, which
we do not have anymore.  For creating a full installation set, the fixed
addresses are not necessary.

I also looked at your patch.  Looks good.  Just one question and one remark:
Q: In the changes to configure.in I saw the lines
    # some systems need this. Like Ubuntu....
    AC_CHECK_LIB(m, floor)
    AC_CHECK_LIB(dl, dlopen)
Can you explain why that is necessary?  And, do we need them in other places,
too?

R: Maybe you can add a guard to the makefile of coinmp that excludes building
the external library when system CoinMP is used.  That should not be strictly
necessary (with adding COINMP only conditionally to BUILD_TYPE) but we have
these guards in other modules.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Mime
View raw message