incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 119357] Sometimes no download link when JavaScript enabled in Firefox 12
Date Wed, 16 May 2012 10:36:22 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=119357

--- Comment #6 from DonJaime <donjaime@freenet.de> ---
(In reply to comment #3)
> I thought of all the output, not only the first lines. ;-)

That was all of the output. Same bug as on the download page. The Error Console
shows:

Error: language is not defined
Source File: http://www.openoffice.org/download/download2.js
Line: 14

The good news is that I've identified the reason for the difference: I have no
preferred language defined in my "Content" options. Probably not a common
choice, but it can happen.

The solution proposed above is still valid. Or you could declare the language
variable with 'var' (good practice anyhow) and leave out the 'typeof' test, but
you'd still need to change the condition to cover language == undefined. Taking
the quotes off the "null" would do that:

if (language == "" || language == null || language == "en") language = "en-US";

but

if (!language || language == "en") language = "en-US";

would cover everything more elegantly.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message