incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 112701] Replace in Current selection -> incorrect replacement leads to Undo Crash
Date Fri, 18 May 2012 02:03:49 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=112701

--- Comment #5 from Pedro Giffuni <pfg@apache.org> ---
Created attachment 77561
  --> https://issues.apache.org/ooo/attachment.cgi?id=77561&action=edit
Same patch with style changes

The patch looks good, however I made some style changes:

1) We try to avoid hardcoding where the patch starts/ends, this can be handled
by subversion.
2) We usually add email addresses only in the SVN log with a description of the
code and the date.
3) Try to avoid very long lines so that you don't have to scroll all the screen
to read the patch.
4) Have subversion prepare the patches for you. I used
svn diff main/sw/source/ui/uiview/viewsrch.cxx > patch-i112701

But thanks, the patch looks good!

I would like someone else to test this patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message