incubator-ooo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 118986] [RTF export] crashes when copy an empty line from Writer below a tif picture then paste into spreadsheet
Date Mon, 05 Mar 2012 11:59:53 GMT
https://issues.apache.org/ooo/show_bug.cgi?id=118986

--- Comment #4 from vmiklos <vmiklos@suse.cz> 2012-03-05 11:59:53 UTC ---
[ Please don't take this as an LO-rant, I'm commenting this here as Oliver
asked for it. ]

On Fri, Mar 02, 2012 at 10:05:07AM +0100, Oliver-Rainer Wittmann
<orwittmann@googlemail.com> wrote:
> Is it possible to postpone the creation of the image data to the       
> point when they are needed instead of keeping them in memory?

That's exacly what I implemented. The idea is:

- create a wrapper around OStringBuffer, that can remember the arguments
  to a RtfAttributeOutput::FlyFrameGraphic() call
- instead of calling that method, just append the arguments to this
  RtfStringBuffer
- call FlyFrameGraphic() when we can write to the stream directly

FYI, here are the patches:

- refactoring for RtfStringBuffer:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=85887d554141c33d4a9803ab2fd7765dadf7e64d
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4ed3acc18e70a6c867e827c19f8ccf7fa925b9c5
http://cgit.freedesktop.org/libreoffice/core/commit/?id=9b6e7eb1bad4344be0e766f4c05f0a3f28cb737d

- the real fix:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=622ce4681dbcddfdd5cbcd95ebbf1f14e93489ed

valgrind's massif says the peak memory usage is now 1.048GB -> 330.1MB,
which should be on par with the old export.

-- 
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Mime
View raw message