incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From li zhang <lizh....@gmail.com>
Subject [call for review] One fix about performanc​e improvemen​t(xlsx loading)
Date Wed, 10 Oct 2012 08:51:49 GMT
hi, all
I have one fix need for review. Please check the below for details, thanks!

it is about xlsx loading:
https://issues.apache.org/ooo/show_bug.cgi?id=121190

Root cause:
UpdatePageBreaks was called many times wrongly when loading.


Resolution:
1. temporarily disable 'UpdatePageBreaks' in WorkbookGlobals::initialize(
bool bWorkbookFile )
2. disable 'UpdatePageBreaks' in loading .xlsx format file in function
ScTable::UpdatePageBreaks( const ScRange* pUserArea )
3. enable 'UpdatePageBreaks' after loading finish in
WorkbookGlobals::finalize()

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message