incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clarence GUO <clarence.guo...@gmail.com>
Subject Re: Bitmap resampling in symphony? review for i121233)
Date Mon, 22 Oct 2012 07:04:23 GMT
Hello, Pedro
I checked Symphony code, the code you mentioned in vcl of Symphony is to
fix the problem of poor rendering quality of bitmps in the case that
destination image is smaller or larger than the source image.
Symphony code and the patch of bug
121233<https://issues.apache.org/ooo/show_bug.cgi?id=121233>modified
the same files, same functions. There are some conflicts about
BMP_SCALE_BICUBIC(121233) and BMP_SCALE_SUPER(Symphony).
I have a question about BMP_SCALE_BICUBIC, why there's no caller to call
Bitmap::Scale with this scale flag? Then how does this flag works?
And about BMP_SCALE_SUPER, it has a caller, aBmp.Scale ( aSize,
BMP_SCALE_SUPER ) by default in OutputDevice::ImplDrawBitmap in the case:
if ( META_BMPSCALE_ACTION == nAction && (aPosAry.mnSrcWidth >=
aPosAry.mnDestWidth || aPosAry.mnSrcHeight >= aPosAry.mnDestHeight) )

So if BMP_SCALE_BICUBIC will not be called at the same place of Symphony,
there will not be conflicts. Then Tomaz can commit his change first.


2012/10/19 Pedro Giffuni <pfg@apache.org>

> Hello Clarence;
>
> Tomaz has acknowleged that the Symphony code is interesting
> and that it should be enabled by default.
>
> It would be great if someone from Symphony takes the initiative:
> its a good time to start merging those hidden jewels :).
>
> Pedro.
>
>
>
> ----- Original Message -----
> > From: Clarence GUO <clarence.guo.bj@gmail.com>
> > To: ooo-dev@incubator.apache.org; Pedro Giffuni <pfg@apache.org>
> > Cc:
> > Sent: Thursday, October 18, 2012 9:24 PM
> > Subject: Re: Bitmap resampling in symphony? review for i121233)
> >
> > HI~ Pedro,
> > The Symphony's code was there quite a long time ago.
> > We need some time to pick up the background knowledge of the code. Then
> we
> > will give you further information.
> >
> > Thanks & BRs
> > Clarence
> >
> > 2012/10/19 Pedro Giffuni <pfg@apache.org>
> >
> >>  Hello;
> >>
> >>  Thanks to Toma┼ż Vajngerl we now have lanczos and bicubic resampling for
> >>  bitmaps.
> >>
> >>  Looking at similar code in the symphony:
> >>
> >>  symphony/trunk/main/vcl/inc/vcl/bitmap.hxx (line 54)
> >>
> >>  ...
> >>   #define BMP_SCALE_SUPER             0x00000004UL
> >>  ...
> >>
> >>  Which would be in (minor) conflict with the change in BZ i121233.
> >>
> >>  Perhaps someone from Symphony may want to take a look to see
> >>  if there is something that we should bring from Symphony first and
> >>  how to better adapt the new code?
> >>
> >>  best regards,
> >>
> >>  Pedro.
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message