Mailing-List: contact ooo-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: ooo-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of awf.aoo@gmail.com designates
 209.85.214.47 as permitted sender)
Message-ID: <5062C3C4.5010609@googlemail.com>
Date: Wed, 26 Sep 2012 10:58:44 +0200
From: Andre <awf.aoo@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:15.0) Gecko/20120827 Thunderbird/15.0
MIME-Version: 1.0
To: ooo-dev@incubator.apache.org
Subject: Re: WaE: sd/source/ui/slideshow/slideshowimpl.cxx
References: <279B7438-C697-424B-AA2A-75A343718A2E@Janik.cz>
 <5062C095.9020808@googlemail.com>
 <87F02611-C7FF-4497-938D-3273A01B85F7@Janik.cz>
In-Reply-To: <87F02611-C7FF-4497-938D-3273A01B85F7@Janik.cz>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit

On 09/26/2012 10:48 AM, Pavel Jan�k wrote:
> On Sep 26, 2012, at 10:45 AM, Andre wrote:
>
>> On 09/25/2012 07:57 PM, Pavel Jan�k wrote:
>>> Hi,
>>>
>>> this code emits Warning about unused bLoad:
>>>
>>> bool bLoad = vcl::ImageRepository::loadBrandingImage(
>>>                    rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "logo" ) ),
>>>                                   aImage );
>>> OSL_ENSURE( bLoad, "Can't load logo image");
>>>
>>> Can't we OSL_ENSURE that aImage is initialized properly instead?
>> Maybe we can do that additionally, loading is not the same as initialization.
>> I would just add
>>
>>     (void)bLoad;
> That was my first guess, but the code looks strange this way ;-)

I agree :-)

> But I'd let this decision on the author of the code.

I don�t know if he still monitors this list.

-Andre