incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Weir <robw...@apache.org>
Subject Re: build svtools with debug
Date Wed, 26 Sep 2012 17:53:12 GMT
On Wed, Sep 26, 2012 at 12:27 PM, J├╝rgen Schmidt <jogischmidt@gmail.com> wrote:
> On 9/26/12 6:19 PM, Armin Le Grand wrote:
>> On 26.09.2012 17:57, Regina Henschel wrote:
>>> Hi Armin
>>>
>>> Armin Le Grand schrieb:
>>>> Hi List,
>>>>
>>>> with current trunk I cannot build svtools with debug, e.g.
>>>>
>>>> cd svtools
>>>> make clean
>>>> make clean debug=t
>>>> make -sr -j8 debug=t
>>>>
>>>> -> Lots of unresolved externals from stl. Yes, I'm using stlport, and
>>>> I'm on windows.
>>>>
>>>> I tried to also build stlport with debug and delivered it, but does not
>>>> help.
>>>>
>>>> Can someone help...?
>>>
>>> I've got a debug build with MSVC 9.0 Express of r1389055. That's from
>>> Sunday 23.Sept. I've made a clean build, including "cleaning"
>>> ext_libraries.
>>
>> That's not the problem. I've checked out yesterday and built, works
>> well. This is a non-pro build. The problems comes up when you wahnt to
>> build svtools with 'debug=t' to enable it for source level debugging.
>>
>> Thus, this is not a build breaker (as long as noone is building with
>> debug=t for all modules) and would have not been found initially by
>> working in a branch (implying that on a branch the diverse plattform
>> build would have been done, noone will build single modules with debug=t
>> there).
>>
>> When finding something like this I think it is not wrong to evtl. revert
>> on trunk, go back on a branch and try to find out why a concrete case
>> does not work (as with svtools here).
>>
>> I builded a lot of other modules in this working copy with debug=t, all
>> worked well except svtools...
>>
>> The question is how long will we be able to live with not being able to
>> debug in svtools on windows? Not a good situation...
>>
>> I just found out that svtlls part called hatchwindowfactory *can* be
>> linked when adding the following:
>>
>> Index: Library_hatchwindowfactory.mk
>> ===================================================================
>> --- Library_hatchwindowfactory.mk       (revision 1389804)
>> +++ Library_hatchwindowfactory.mk       (working copy)
>> @@ -43,6 +43,7 @@
>>         tk \
>>         tl \
>>         vcl \
>> +       stl \
>>         $(gb_STDLIBS) \
>>  ))
>>
>> @Pedro: Is this a solution? Maybe when using debug, extra stuff using
>> stl to verify things (remember data in a vector?) gets compiled. I do
>> not know how bad it is to always link against stl for
>> hatchwindowfactory, even without debug build. What do You think?
>>
>>
>
> thanks Armin for your update and I would like to make clear that my
> interest is to find a common agreement on an approach how we can handle
> such problems in the future. Maybe this specific one is now solved, we
> will see but in general we need an approach where we can all agree on.
>

I think the answer would probably depend on the scope of the change.
A localized change might only call for building on one platform, one
configuration.  But a change that is global in nature might call for a
wider set of builds to confirm the correctness of the patch.  Errors
are unpredictable.  All we really can predict is the scope of impact
of an error if it occurs.  So if a change could break all modules in
all platforms and bring everyone's work to a screeching halt, then
that suggests further diligence in that patch.

Of course, this will be much easier once we have buildbot support on
all platforms *and* the ability for any committer  to trigger an
automated build on a branch.   If we make this painless then I think
there would be few arguments against this.

-Rob

> We should continue this discussion probably in a new thread.
>
> Juergen
>
>
>>> Kind regards
>>> Regina
>>>
>>>>
>>>> Output is:
>>>>
>>>> --------------8<-----------------------------------8<---------------------
>>>>
>>>>
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/CxxObject/svtools/source/hatchwindow/documentcloser.o
>>>>
>>>>
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/CxxObject/svtools/source/hatchwindow/hatchwindow.o
>>>>
>>>>
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/CxxObject/svtools/source/hatchwindow/hatchwindowfactory.o
>>>>
>>>>
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/CxxObject/svtools/source/hatchwindow/ipwin.o
>>>>
>>>>
>>>>
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/WinResTarget/hatchwindowfactory/default.res
>>>>
>>>>
>>>>
>>>>     Creating library
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/LinkTarget/Library/ihatchwindowfactory.lib
>>>>
>>>>
>>>> and object
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/LinkTarget/Library/ihatchwindowfactory.exp
>>>>
>>>>
>>>>
>>>> documentcloser.o : error LNK2019: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::_Loc_init(void)"
>>>> (__imp_??0_Loc_init@ios_base@_STL@@QAE@XZ) referenced in function "void
>>>> __cdecl _STL::`dynamic initializer for '_LocInit''(void)"
>>>> (??__E_LocInit@_STL@@YAXXZ)
>>>> hatchwindow.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::_Loc_init(void)"
>>>> (__imp_??0_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> hatchwindowfactory.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::_Loc_init(void)"
>>>> (__imp_??0_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> ipwin.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::_Loc_init(void)"
>>>> (__imp_??0_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> documentcloser.o : error LNK2019: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::Init(void)" (__imp_??0Init@ios_base@_STL@@QAE@XZ)
>>>> referenced in function "void __cdecl _STL::`dynamic initializer for
>>>> '_IosInit''(void)" (??__E_IosInit@_STL@@YAXXZ)
>>>> hatchwindow.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::Init(void)" (__imp_??0Init@ios_base@_STL@@QAE@XZ)
>>>> hatchwindowfactory.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::Init(void)" (__imp_??0Init@ios_base@_STL@@QAE@XZ)
>>>> ipwin.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::Init(void)" (__imp_??0Init@ios_base@_STL@@QAE@XZ)
>>>> documentcloser.o : error LNK2019: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::~_Loc_init(void)"
>>>> (__imp_??1_Loc_init@ios_base@_STL@@QAE@XZ) referenced in function "void
>>>> __cdecl _STL::`dynamic atexit destructor for '_LocInit''(void)"
>>>> (??__F_LocInit@_STL@@YAXXZ)
>>>> hatchwindow.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::~_Loc_init(void)"
>>>> (__imp_??1_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> hatchwindowfactory.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::~_Loc_init(void)"
>>>> (__imp_??1_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> ipwin.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::_Loc_init::~_Loc_init(void)"
>>>> (__imp_??1_Loc_init@ios_base@_STL@@QAE@XZ)
>>>> documentcloser.o : error LNK2019: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::~Init(void)" (__imp_??1Init@ios_base@_STL@@QAE@XZ)
>>>> referenced in function "void __cdecl _STL::`dynamic atexit destructor
>>>> for '_IosInit''(void)" (??__F_IosInit@_STL@@YAXXZ)
>>>> hatchwindow.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::~Init(void)" (__imp_??1Init@ios_base@_STL@@QAE@XZ)
>>>> hatchwindowfactory.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::~Init(void)" (__imp_??1Init@ios_base@_STL@@QAE@XZ)
>>>> ipwin.o : error LNK2001: unresolved external symbol
>>>> "__declspec(dllimport) public: __thiscall
>>>> _STL::ios_base::Init::~Init(void)" (__imp_??1Init@ios_base@_STL@@QAE@XZ)
>>>> c:/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/LinkTarget/Library/hatchwindowfactory.uno.dll
>>>>
>>>>
>>>> : fatal error LNK1120: 4 unresolved externals
>>>> /bin/cp: cannot stat
>>>> `/cygdrive/c/aoo/svn_trunk16/main/solver/350/wntmsci12/workdir/LinkTarget/Library/ihatchwindowfactory.lib':
>>>>
>>>>
>>>> No such file or directory
>>>> --------------8<-----------------------------------8<---------------------
>>>>
>>>>
>>>>
>>>> Sincerely,
>>>>      Armin
>>>> --
>>>> ALG
>>>>
>>>>
>>>
>>>
>>
>

Mime
View raw message