incubator-ooo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fan Zheng <zheng.easy...@gmail.com>
Subject [call for review] Re: svn commit: r1386590 - in /incubator/ooo/trunk: ./ main/sw/inc/ main/sw/source/core/doc/ main/sw/source/core/tox/ main/sw/source/filter/ww8/ main/sw/source/filter/ww8/dump/ main/sw/source/ui/index/ test/ test/testcommon/source/o
Date Fri, 21 Sep 2012 10:44:41 GMT
Hi, Pavel:

I have aleady open a issue 121066 in BugZilla, and also supplied a patch
for it.
https://issues.apache.org/ooo/show_bug.cgi?id=121066

Do you have any time on reviewing the codes? Or any other volunteers?

Thanks a lot!

2012/9/18 Pavel Janík <Pavel@janik.cz>

> Hi,
>
> On Sep 17, 2012, at 2:46 PM, orw@apache.org wrote:
>
> > +void WW8_WrtBookmarks::MoveFieldMarks(sal_uLong nFrom,sal_uLong nTo)
> > +{
> > +    std::pair<CPItr,CPItr> aRange = aSttCps.equal_range(nFrom);
> > +    CPItr aItr = aRange.first;
> > +    while (aItr != aRange.second)
> > +    {
> > +        if (aItr->second)
> > +        {
> > +            if (aItr->second->first == nFrom)
>
> the last line is a source of compiler warning:
>
> sw/source/filter/ww8/wrtww8.cxx: In member function ‘void
> WW8_WrtBookmarks::MoveFieldMarks(sal_uLong, sal_uLong)’:
> sw/source/filter/ww8/wrtww8.cxx:315: warning: comparison between signed
> and unsigned integer expressions
>
> Can you please fix it?
> --
> Pavel Janík
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message